Send app source when chatting with Concierge, after redirection from OldDot #34590

cristipaval · 2024-01-16T16:38:13Z

We need to know in BE if the user is texting Concierge after coming from OldDot. This is needed for the agents to know if the user has questions related to OldDot or NewDot.

Fixed Issues

https://github.com/Expensify/Expensify/issues/358241

Tests

On Dev environment only: Make sure you properly set EXPENSIFY_ACCOUNT_ID_CONCIERGE variable in .env file

Launch NewDot on web and go to Concierge
Right click -> Inspect -> Network
Send a message to Concierge (let them know you're testing a PR if you're on staging)
Verify that isOldDotConciergeChat parameter is not sent along with the AddComment command
Go to OldDot and open Concierge from there
Repeat steps 2 and 3 from above
Verify that isOldDotConciergeChat parameter is sent along with the AddComment command

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests, just make sure that you're specifying in the messages sent to the Concierge that you're testing a PR and no action is needed,

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-01-16T17:04:50Z

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-01-16T17:07:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Having issues with the android build

Android: mWeb Chrome

Screen.Recording.2024-01-16.at.10.31.45.PM.mov

iOS: Native

Screen.Recording.2024-01-16.at.10.30.54.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-01-16.at.10.30.19.PM.mov

MacOS: Chrome / Safari

screen-recording-2024-01-16-at-102642-pm_qpXFlw5P.mp4

MacOS: Desktop

allroundexperts · 2024-01-16T17:33:35Z

src/libs/actions/Report.ts

+Linking.getInitialURL().then((url) => {
+    const params = new URLSearchParams(url ?? '');
+    const exitToRoute = params.get('exitTo') ?? '';
+    const {reportID} = ReportUtils.parseReportRouteParams(exitToRoute);
+    reportIDDeeplinkedFromOldDot = reportID;
+});


Why wasn't this added in a useEffect with an empty dependency list?

Just wanted to avoid passing this ugly parameter from a component to the Report.addComment and Report.addAttachment functions. Do we have a best practice or a guideline related to this? 👀

I don't know of any. I guess this is fine as it is then.

allroundexperts

Looks good!

melvin-bot · 2024-01-16T17:58:20Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-01-16T17:58:23Z

🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #34594.

marcochavezf

The code LGTM

marcochavezf · 2024-01-16T23:32:43Z

Merging since it's a critical issue

OSBotify · 2024-01-16T23:38:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mvtglobally · 2024-01-18T01:21:40Z

isOldDotConciergeChat parameter isn't visible
This seem to be failing on the second part. Can you pls double check if this is expected? When you start from OD, the parameter is expected, But we dont see it.

Go to OD and click on the Concierge chat
In the new ND tab, open the network tab in Chrome console
Message Concierge the following "MODERATION_TEST"

bandicam.2024-01-17.20-30-13-778.mp4

mountiny · 2024-01-18T01:52:15Z

In the video we cannot see you have checked the params @mvtglobally

mvtglobally · 2024-01-18T01:54:46Z

@mountiny Are you saying we are looking in the wrong place? It is on the right of the video

mountiny · 2024-01-18T01:57:40Z

@mvtglobally you need to click into the AddComment in the networks tab and then preview section of that request you should be able to see the parameters of the request

OSBotify · 2024-01-18T03:14:38Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.26-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

cristipaval added 3 commits January 15, 2024 21:30

Verify if the user comes from OldDot

23012c7

Create ReportUtils.isOldDotConciergeChat function

020a22b

Try a new approach

34d6d90

cristipaval self-assigned this Jan 16, 2024

cristipaval added 3 commits January 16, 2024 18:43

Revert initial changes

9eaddcd

Remove console logs

c71299b

Run prettier

4524a3e

cristipaval marked this pull request as ready for review January 16, 2024 17:04

cristipaval requested a review from a team as a code owner January 16, 2024 17:04

melvin-bot bot requested review from MonilBhavsar and removed request for a team January 16, 2024 17:04

cristipaval requested a review from allroundexperts January 16, 2024 17:05

allroundexperts reviewed Jan 16, 2024

View reviewed changes

allroundexperts approved these changes Jan 16, 2024

View reviewed changes

melvin-bot bot requested a review from marcochavezf January 16, 2024 17:58

melvin-bot bot mentioned this pull request Jan 16, 2024

Payment issue for E/App PR#34590 #34594

Closed

marcochavezf approved these changes Jan 16, 2024

View reviewed changes

marcochavezf merged commit 0710726 into main Jan 16, 2024
17 of 19 checks passed

marcochavezf deleted the cristi_send-app-source-when-chatting-with-concierge branch January 16, 2024 23:32

github-actions bot mentioned this pull request Jan 17, 2024

Deploy Checklist: New Expensify 2024-01-17 #34621

Closed

58 tasks

cristipaval requested a review from AndrewGable January 17, 2024 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send app source when chatting with Concierge, after redirection from OldDot #34590

Send app source when chatting with Concierge, after redirection from OldDot #34590

cristipaval commented Jan 16, 2024 •

edited

Loading

melvin-bot bot commented Jan 16, 2024

allroundexperts commented Jan 16, 2024 •

edited

Loading

allroundexperts Jan 16, 2024

cristipaval Jan 16, 2024

allroundexperts Jan 16, 2024

allroundexperts left a comment

melvin-bot bot commented Jan 16, 2024

melvin-bot bot commented Jan 16, 2024

marcochavezf left a comment

marcochavezf commented Jan 16, 2024

OSBotify commented Jan 16, 2024

mvtglobally commented Jan 18, 2024

mountiny commented Jan 18, 2024

mvtglobally commented Jan 18, 2024

mountiny commented Jan 18, 2024

OSBotify commented Jan 18, 2024

Send app source when chatting with Concierge, after redirection from OldDot #34590

Send app source when chatting with Concierge, after redirection from OldDot #34590

Conversation

cristipaval commented Jan 16, 2024 • edited Loading

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 16, 2024

allroundexperts commented Jan 16, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts Jan 16, 2024

Choose a reason for hiding this comment

cristipaval Jan 16, 2024

Choose a reason for hiding this comment

allroundexperts Jan 16, 2024

Choose a reason for hiding this comment

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jan 16, 2024

melvin-bot bot commented Jan 16, 2024

marcochavezf left a comment

Choose a reason for hiding this comment

marcochavezf commented Jan 16, 2024

OSBotify commented Jan 16, 2024

mvtglobally commented Jan 18, 2024

mountiny commented Jan 18, 2024

mvtglobally commented Jan 18, 2024

mountiny commented Jan 18, 2024

OSBotify commented Jan 18, 2024

cristipaval commented Jan 16, 2024 •

edited

Loading

allroundexperts commented Jan 16, 2024 •

edited

Loading