[TS migration] Migrate 'EmojiPicker' component to TypeScript #37641

HezekielT · 2024-03-01T20:55:32Z

Details

Migrates EmojiPicker to typescript.

Fixed Issues

$ #25155
PROPOSAL:

Tests

Open any Report.
Click on the emoji picker and verify it is working.
Select an emoji from the emoji picker and verify it is working.
Go to Settings => Profile and click on the status icon.
Click on the dropdown and verify the emoji picker is opened.
Select an emoji from the emoji picker and verify it is working.

Verify that no errors appear in the JS console

Offline tests

Same as Tests section.

QA Steps

Same as Tests section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_migrate_emojiPicker_to_ts.mov

Android: mWeb Chrome

mweb_emoji_picker.mov

iOS: Native

ios_native_emoji_picker.mov

iOS: mWeb Safari

ios_safari_Emoji_picker.mov

MacOS: Chrome / Safari

Web_emojiPicker.mov

MacOS: Desktop

desktop_emoji_picker.mov

melvin-bot · 2024-03-05T22:56:35Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

HezekielT · 2024-03-05T22:58:47Z

@abdulrahuman5196 I will add the remaining platform videos shortly, other than that PR is ready for review.

HezekielT · 2024-03-05T22:59:44Z

cc @blazejkustra

blazejkustra

Overall good work! 🤟

src/components/EmojiPicker/EmojiSkinToneList.tsx

src/components/EmojiPicker/EmojiPickerMenuItem/types.ts

src/components/EmojiPicker/EmojiPickerMenuItem/index.native.tsx

src/components/EmojiPicker/EmojiPickerMenu/BaseEmojiPickerMenu.tsx

src/components/EmojiPicker/EmojiPickerButtonDropdown.tsx

src/components/EmojiPicker/CategoryShortcutButton.tsx

src/components/EmojiPicker/EmojiPicker.tsx

src/components/EmojiPicker/EmojiPickerButton.tsx

src/components/EmojiPicker/EmojiPickerButtonDropdown.tsx

src/components/EmojiPicker/EmojiPickerMenu/BaseEmojiPickerMenu.tsx

src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx

src/components/EmojiPicker/EmojiSkinToneList.tsx

src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx

blazejkustra

Added some comments regarding assertion, let's try to get rid of them. Other than that I think we are very close 🚀

src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx

src/components/EmojiPicker/EmojiPicker.tsx

src/components/EmojiPicker/EmojiPickerMenu/BaseEmojiPickerMenu.tsx

src/components/EmojiPicker/EmojiPickerMenu/useEmojiPickerMenu.ts

blazejkustra · 2024-03-18T20:27:57Z

@HezekielT Let's continue migrating, I believe we are very close 🙏

HezekielT · 2024-03-18T20:45:57Z

@blazejkustra Apologies for the delay, I've been busy the last few days. I will try to push the changes you suggested asap. Thanks for the patience. 🙏

blazejkustra

Small comments, otherwise LGTM! LEt's test it thoroughly :D

src/components/EmojiPicker/EmojiPicker.tsx

src/components/EmojiPicker/EmojiPickerButtonDropdown.tsx

src/components/Form/types.ts

fabioh8010 · 2024-03-26T06:54:30Z

@HezekielT we have conflicts here. Could you resolve them and tag @abdulrahuman5196 to review the PR? Thanks!

HezekielT · 2024-03-26T14:41:43Z

@abdulrahuman5196 Could you please review this PR when you get the chance? 🙏 Thanks!

melvin-bot · 2024-03-26T16:40:21Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

kubabutkiewicz

one nit , lgtm!

kubabutkiewicz · 2024-03-26T17:14:12Z

src/components/EmojiPicker/CategoryShortcutBar.tsx

                <CategoryShortcutButton
                    icon={headerEmoji.icon}
-                    onPress={() => props.onPress(headerEmoji.index)}
+                    onPress={() => onPress(headerEmoji.index)}
+                    // eslint-disable-next-line react/no-array-index-key


maybe we can use something better for index instead of disabling this line?

@HezekielT bump on this

I think we can use headerEmoji.index instead of i 👍

replaced the array index usage by headerEmoji.index @kubabutkiewicz

fabioh8010 · 2024-03-28T08:37:39Z

@abdulrahuman5196 bump

kubabutkiewicz · 2024-03-29T15:50:28Z

@HezekielT Can you merge main?
@abdulrahuman5196 kind bump 😄

abdulrahuman5196 · 2024-04-01T08:59:11Z

Hi, Will work on review today.

abdulrahuman5196 · 2024-04-01T16:39:59Z

@HezekielT
The cursor is moving wrongly when selecting an emoji in the desktop app

Screen.Recording.2024-04-01.at.10.08.26.PM.mov

HezekielT · 2024-04-01T23:20:20Z

Thanks @abdulrahuman5196 for the review. I will investigate why the bug is happening.

HezekielT · 2024-04-03T10:28:04Z

@abdulrahuman5196 The issue should be fixed now. Could you please review again when you get the chance? Thanks.

….tsx Co-authored-by: Błażej Kustra <[email protected]>

HezekielT · 2024-04-08T13:07:25Z

@abdulrahuman5196 merged the latest main and fixed the conflict 👍

abdulrahuman5196 · 2024-04-08T19:14:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-09.at.12.22.59.AM.mp4

Android: mWeb Chrome

Screen.Recording.2024-04-09.at.12.34.27.AM.mp4

iOS: Native

Screen.Recording.2024-04-09.at.12.11.45.AM.mp4

iOS: mWeb Safari

Screen.Recording.2024-04-09.at.12.17.13.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-04-09.at.12.05.26.AM.mp4

MacOS: Desktop

Screen.Recording.2024-04-09.at.12.07.22.AM.mp4

abdulrahuman5196 · 2024-04-08T19:19:48Z

I am seeing couple of issues in composer selection after selecting emoji. These issues are also available in staging so I don't think its required to hold this PR for that.
The issues also present in the videos attached.

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @tylerkaraszewski

🎀 👀 🎀
C+ Reviewed

OSBotify · 2024-04-09T00:16:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-10T17:45:24Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T17:54:17Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-04-10T19:33:30Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.62-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-18T04:31:15Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 · 2024-10-29T03:22:13Z

src/components/EmojiPicker/EmojiPicker.tsx

@@ -50,34 +53,39 @@ const EmojiPicker = forwardRef((props, ref) => {
     *
     * Don't directly get the ref from emojiPopoverAnchorRef, instead use getEmojiPopoverAnchor()
     */
-    const getEmojiPopoverAnchor = useCallback(() => emojiPopoverAnchorRef.current || emojiPopoverAnchorRef, []);
+    const getEmojiPopoverAnchor = useCallback(() => emojiPopoverAnchorRef.current ?? emojiPopoverAnchorRef?.current, []);


It should be emojiPopoverAnchorRef same as the original code

HezekielT force-pushed the migrate/25155 branch from 0f8b192 to 46c24ef Compare March 5, 2024 19:49

HezekielT marked this pull request as ready for review March 5, 2024 22:56

HezekielT requested a review from a team as a code owner March 5, 2024 22:56

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team March 5, 2024 22:56

blazejkustra suggested changes Mar 6, 2024

View reviewed changes

kubabutkiewicz reviewed Mar 11, 2024

View reviewed changes

HezekielT requested review from kubabutkiewicz and blazejkustra March 13, 2024 13:44

blazejkustra suggested changes Mar 13, 2024

View reviewed changes

HezekielT force-pushed the migrate/25155 branch from 9950168 to fdedba1 Compare March 22, 2024 14:49

HezekielT requested a review from blazejkustra March 25, 2024 10:51

blazejkustra approved these changes Mar 25, 2024

View reviewed changes

src/components/EmojiPicker/EmojiPicker.tsx Show resolved Hide resolved

src/components/EmojiPicker/EmojiPickerButtonDropdown.tsx Outdated Show resolved Hide resolved

src/components/Form/types.ts Show resolved Hide resolved

HezekielT force-pushed the migrate/25155 branch from 8f32c47 to 09bac6c Compare March 26, 2024 14:35

kubabutkiewicz approved these changes Mar 26, 2024

View reviewed changes

HezekielT force-pushed the migrate/25155 branch from 09bac6c to 1f13dce Compare March 29, 2024 16:41

HezekielT and others added 13 commits April 8, 2024 16:02

improve code

abc8a60

run prettier

e192774

add default props

f8da5fa

Update src/components/EmojiPicker/EmojiPickerMenu/BaseEmojiPickerMenu…

22fbbe8

….tsx Co-authored-by: Błażej Kustra <[email protected]>

code cleanup

4423c09

code changes based on review

9085bc8

code changes based on review

1085811

code changes based on review

3932433

remove type assertion

da9e52f

fix ts errors

ee852df

code changes based on review

4192624

replaced array index usage by headerEmoji.index

27a2dd5

fix cursor issue

dd6327f

HezekielT force-pushed the migrate/25155 branch from 9556c3f to dd6327f Compare April 8, 2024 13:04

abdulrahuman5196 approved these changes Apr 8, 2024

View reviewed changes

melvin-bot bot requested a review from tylerkaraszewski April 8, 2024 19:23

tylerkaraszewski approved these changes Apr 8, 2024

View reviewed changes

tylerkaraszewski merged commit 0f4c845 into Expensify:main Apr 9, 2024
16 checks passed

github-actions bot mentioned this pull request Apr 10, 2024

Deploy Checklist: New Expensify 2024-04-10 #40026

Closed

melvin-bot bot mentioned this pull request Apr 18, 2024

[HOLD for payment 2024-04-25] [$250] [TS migration] Migrate 'EmojiPicker' component to TypeScript #25155

Closed

bernhardoj mentioned this pull request Oct 7, 2024

[HOLD for payment 2024-10-29] [$250] Chat - When emoji picker is opened, right-clicking on message opens and closes context menu #50314

Closed

6 tasks

dukenv0307 reviewed Oct 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'EmojiPicker' component to TypeScript #37641

[TS migration] Migrate 'EmojiPicker' component to TypeScript #37641

HezekielT commented Mar 1, 2024 •

edited

Loading

melvin-bot bot commented Mar 5, 2024

HezekielT commented Mar 5, 2024 •

edited

Loading

HezekielT commented Mar 5, 2024

blazejkustra left a comment

blazejkustra left a comment •

edited

Loading

blazejkustra commented Mar 18, 2024

HezekielT commented Mar 18, 2024

blazejkustra left a comment

fabioh8010 commented Mar 26, 2024

HezekielT commented Mar 26, 2024

melvin-bot bot commented Mar 26, 2024

kubabutkiewicz left a comment

kubabutkiewicz Mar 26, 2024

fabioh8010 Mar 28, 2024

HezekielT Mar 28, 2024

HezekielT Mar 29, 2024

fabioh8010 commented Mar 28, 2024

kubabutkiewicz commented Mar 29, 2024

abdulrahuman5196 commented Apr 1, 2024

abdulrahuman5196 commented Apr 1, 2024

HezekielT commented Apr 1, 2024

HezekielT commented Apr 3, 2024

HezekielT commented Apr 8, 2024

abdulrahuman5196 commented Apr 8, 2024 •

edited

Loading

abdulrahuman5196 commented Apr 8, 2024 •

edited

Loading

abdulrahuman5196 left a comment

OSBotify commented Apr 9, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 18, 2024

dukenv0307 Oct 29, 2024

[TS migration] Migrate 'EmojiPicker' component to TypeScript #37641

[TS migration] Migrate 'EmojiPicker' component to TypeScript #37641

Conversation

HezekielT commented Mar 1, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 5, 2024

HezekielT commented Mar 5, 2024 • edited Loading

HezekielT commented Mar 5, 2024

blazejkustra left a comment

Choose a reason for hiding this comment

blazejkustra left a comment • edited Loading

Choose a reason for hiding this comment

blazejkustra commented Mar 18, 2024

HezekielT commented Mar 18, 2024

blazejkustra left a comment

Choose a reason for hiding this comment

fabioh8010 commented Mar 26, 2024

HezekielT commented Mar 26, 2024

melvin-bot bot commented Mar 26, 2024

kubabutkiewicz left a comment

Choose a reason for hiding this comment

kubabutkiewicz Mar 26, 2024

Choose a reason for hiding this comment

fabioh8010 Mar 28, 2024

Choose a reason for hiding this comment

HezekielT Mar 28, 2024

Choose a reason for hiding this comment

HezekielT Mar 29, 2024

Choose a reason for hiding this comment

fabioh8010 commented Mar 28, 2024

kubabutkiewicz commented Mar 29, 2024

abdulrahuman5196 commented Apr 1, 2024

abdulrahuman5196 commented Apr 1, 2024

HezekielT commented Apr 1, 2024

HezekielT commented Apr 3, 2024

HezekielT commented Apr 8, 2024

abdulrahuman5196 commented Apr 8, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 commented Apr 8, 2024 • edited Loading

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 9, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 10, 2024

OSBotify commented Apr 18, 2024

dukenv0307 Oct 29, 2024

Choose a reason for hiding this comment

HezekielT commented Mar 1, 2024 •

edited

Loading

HezekielT commented Mar 5, 2024 •

edited

Loading

blazejkustra left a comment •

edited

Loading

abdulrahuman5196 commented Apr 8, 2024 •

edited

Loading

abdulrahuman5196 commented Apr 8, 2024 •

edited

Loading