Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite spinner in ND when navigating from OD #38567

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "add shouldSkipDeepLinkNavigation for all platforms"
This reverts commit 7488983.
  • Loading branch information
adamgrzybowski committed Mar 19, 2024
commit 0cbbf29e0448bf931c7ad18ac098010db6b600ae
5 changes: 5 additions & 0 deletions src/libs/shouldSkipDeepLinkNavigation/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// eslint-disable-next-line @typescript-eslint/no-unused-vars
export default function shouldSkipDeepLinkNavigation(route: string) {
// no-op for all other platforms
return false;
}
12 changes: 12 additions & 0 deletions src/libs/shouldSkipDeepLinkNavigation/index.web.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import ROUTES from '@src/ROUTES';

export default function shouldSkipDeepLinkNavigation(route: string) {
// When deep-linking to desktop app with `transition` route we don't want to call navigate
// on the route because it will display an infinite loading indicator.
// See issue: https://github.com/Expensify/App/issues/33149
if (route.includes(ROUTES.TRANSITION_BETWEEN_APPS)) {
return true;
}

return false;
}
Loading