Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite spinner in ND when navigating from OD #38567

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Fix infinite spinner in ND when navigating from OD #38567

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cecb40f
add shouldSkipDeepLinkNavigation for web
adamgrzybowski Mar 19, 2024
7488983
add shouldSkipDeepLinkNavigation for all platforms
adamgrzybowski Mar 19, 2024
0cbbf29
Revert "add shouldSkipDeepLinkNavigation for all platforms"
adamgrzybowski Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/libs/shouldSkipDeepLinkNavigation/index.web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import ROUTES from '@src/ROUTES';

export default function shouldSkipDeepLinkNavigation(route: string) {
// When deep-linking to desktop app with `transition` route we don't want to call navigate
// on the route because it will display an infinite loading indicator.
// See issue: https://github.com/Expensify/App/issues/33149
if (route.includes(ROUTES.TRANSITION_BETWEEN_APPS)) {
return true;
}

return false;
}
Loading