-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Focus not removed when selection list changes. #39141
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
715abef
fix: Focus not removed when selection list changes.
Krishna2323 fd23d80
Merge branch 'Expensify:main' into krishna2323/issue/35665
Krishna2323 d4e034a
Merge branch 'Expensify:main' into krishna2323/issue/35665
Krishna2323 5220450
Merge branch 'Expensify:main' into krishna2323/issue/35665
Krishna2323 b91c089
fix: perf tests.
Krishna2323 9140091
Merge branch 'Expensify:main' into krishna2323/issue/35665
Krishna2323 c295c21
Merge branch 'Expensify:main' into krishna2323/issue/35665
Krishna2323 2a3bc3f
fix: Reassure Performance Tests.
Krishna2323 1b876b1
add all deps.
Krishna2323 7cb09a2
Merge branch 'Expensify:main' into krishna2323/issue/35665
Krishna2323 2fa4845
Merge branch 'Expensify:main' into krishna2323/issue/35665
Krishna2323 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from this issue #36140 (comment), we also need to check all options's length here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from #42583 this was causing the first category search result to not be highlighted.