enable tooltip for group title #40528

Nodebrute · 2024-04-19T02:42:54Z

Details

Fixed Issues

$ #40457
PROPOSAL: #40457 (comment)

Tests

Navigate to the FAB
then select 'Start chat'.
Proceed to create a group chat.
Hover over the name of a group member displayed in the header.
Verify that the tooltip is visible.

Now,

click on the header,
navigate to 'Settings' and select 'Name'.
Change the name and verify that the header reflects the updated name.
Hover over the header to ensure that the tooltip is not visible.
Verify that no errors appear in the JS console

Offline tests

Go offline
Navigate to the FAB
then select 'Start chat'.
Proceed to create a group chat.
Hover over the name of a group member displayed in the header.
Verify that the tooltip is visible.

Now,

click on the header,
navigate to 'Settings' and select 'Name'.
Change the name and verify that the header reflects the updated name.
Hover over the header to ensure that the tooltip is not visible.

QA Steps

Navigate to the FAB
then select 'Start chat'.
Proceed to create a group chat.
Hover over the name of a group member displayed in the header.
Verify that the tooltip is visible.

Now,

click on the header,
navigate to 'Settings' and select 'Name'.
Change the name and verify that the header reflects the updated name.
Hover over the header to ensure that the tooltip is not visible.
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-04-19.at.7.27.35.AM.mov

MacOS: Desktop

Screen.Recording.2024-04-19.at.7.38.09.AM.mov

melvin-bot · 2024-04-19T02:42:59Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2024-04-19T16:58:12Z

src/pages/home/HeaderView.tsx

@@ -202,7 +202,7 @@ function HeaderView({report, personalDetails, parentReport, parentReportAction,
    const brickRoadIndicator = ReportUtils.hasReportNameError(report) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : '';
    const shouldShowBorderBottom = !isTaskReport || !isSmallScreenWidth;
    const shouldDisableDetailPage = ReportUtils.shouldDisableDetailPage(report);
-
+    const shouldUseGroupTitle = report?.reportName !== '';


Suggested change

const shouldUseGroupTitle = report?.reportName !== '';

const shouldUseGroupTitle = isGroupChat && !!report?.reportName;

Limit this to group chat

If the reportName is undefined we should not use full title (checking for truthy is safer than checking for empty string)

s77rt · 2024-04-19T17:09:56Z

While at it, I found a minor bug that we should fix. In src/pages/GroupChatNameEditPage.tsx wrap this call Report.updateGroupChatName in this condition:

if (values[INPUT_IDS.NEW_CHAT_NAME] !== currentChatName) {
    ...
}

The bug:

Create group
Go to change name
Don't change the name and press save
Hover the header names
You should still be able to see tooltips

s77rt · 2024-04-19T17:16:08Z

Do same ^ with Report.setGroupDraft

Nodebrute · 2024-04-19T18:34:13Z

@s77rt Hey, I've made the changes, and the code is functioning well. Could you please test the code again?

s77rt · 2024-04-20T00:18:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

marcaaron

Looks great! Thanks for the fix! And great catch on the minor bug @s77rt 🙇

OSBotify · 2024-04-22T22:02:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-24T00:07:44Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.4.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-25T13:46:03Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

enable tooltip for group title

939e204

Nodebrute requested a review from a team as a code owner April 19, 2024 02:42

melvin-bot bot requested review from s77rt and removed request for a team April 19, 2024 02:42

run prettier

7ca577a

s77rt suggested changes Apr 19, 2024

View reviewed changes

stop api call when user press save without changing name

bd0e9b0

lint error fixed

f09d6de

s77rt approved these changes Apr 20, 2024

View reviewed changes

melvin-bot bot requested a review from marcaaron April 20, 2024 00:19

marcaaron approved these changes Apr 22, 2024

View reviewed changes

marcaaron merged commit 0b110f4 into Expensify:main Apr 22, 2024
16 checks passed

github-actions bot mentioned this pull request Apr 23, 2024

Deploy Checklist: New Expensify 2024-04-23 #40843

Closed

74 tasks

melvin-bot bot mentioned this pull request Apr 25, 2024

[HOLD for payment 2024-05-02] [$250] Group chat - No tooltip when hovering over group member name in the chat header #40457

Closed

6 tasks

Nodebrute mentioned this pull request Apr 30, 2024

fix tooltip for single participants group #41314

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable tooltip for group title #40528

enable tooltip for group title #40528

Nodebrute commented Apr 19, 2024 •

edited

Loading

melvin-bot bot commented Apr 19, 2024

s77rt Apr 19, 2024

s77rt commented Apr 19, 2024

s77rt commented Apr 19, 2024

Nodebrute commented Apr 19, 2024

s77rt commented Apr 20, 2024

marcaaron left a comment

OSBotify commented Apr 22, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

	const shouldUseGroupTitle = report?.reportName !== '';
	const shouldUseGroupTitle = isGroupChat && !!report?.reportName;

enable tooltip for group title #40528

enable tooltip for group title #40528

Conversation

Nodebrute commented Apr 19, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 19, 2024

s77rt Apr 19, 2024

Choose a reason for hiding this comment

s77rt commented Apr 19, 2024

s77rt commented Apr 19, 2024

Nodebrute commented Apr 19, 2024

s77rt commented Apr 20, 2024

Reviewer Checklist

Screenshots/Videos

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 22, 2024

OSBotify commented Apr 24, 2024

OSBotify commented Apr 25, 2024

Nodebrute commented Apr 19, 2024 •

edited

Loading