[Details Revamp] Update ReportDetailsPage for Rooms, Groups, Money Reports and Policy Expenses

[cdOut]

Details

Update for the ReportDetailsPage for all the possible use-cases, such as Rooms and Groups, Money Reports/Requests and Policy Expense Report/Requests.

Fixed Issues

$ #42074
$ #42075
$ #42076
PROPOSAL:

Tests

Workspace Rooms & Groups:

1. Create a new workspace, inside it create a custom room and a chat group with at least two people
2. Go into the newly created rooms, and check for correctness of the following parameters:
3. If the room is not default and the user should be able to leave it, the leave button should appear and be interactable
4. The PromotedActionsBar should be showing the Pin and Share actions, Join if the user is a guest.
5. The name should be displayed in a new way, editable when the rooms aren't the default rooms.
6. Under the name field there should be a small subtext that will either redirect you to the workspace page if you are an admin of said workspace, or just a text displaying the name of the workspace you are a member of.
7. If the room for workspace is a custom user-created room, try viewing it as a guest and confirm that the Join PromotedAction does show and work properly in the PromotedActionsBar.

IOU / Expense Reports:

1. Create a new IOU / Expense report.
2. If the expense is deleteable, the delete button should appear and display the confirmation modal through which you can delete the selected expense.
3. On any of the expenses there should be the PromotedActionsBar displaying the correct values, which are Pin and Share actions, Hold if the expense is available for being held.
4. Please test deleting the expenses throughoutly, check whether all the cases that should be deletable are in fact able to be deleted and this functionality has been revamped properly.

Tasks:

1. Create a new task.
2. If the task isn't completed, the delete button should be displayed after which you will have to confirm the action with a confirmation modal. If you have completed the task, there should be a Mark as incomplete button which will cancel the completion status for the task.
3. PromotedActionsBar should display the pin and share actions.

Here's a table which shows which PromotedActions should be displayed in the PromotedActionsBar for the report in each specific case.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Workspace Rooms & Groups:

1. Create a new workspace, inside it create a custom room and a chat group with at least two people
2. Go into the newly created rooms, and check for correctness of the following parameters:
3. If the room is not default and the user should be able to leave it, the leave button should appear and be interactable
4. The PromotedActionsBar should be showing the Pin and Share actions, Join if the user is a guest.
5. The name should be displayed in a new way, editable when the rooms aren't the default rooms.
6. Under the name field there should be a small subtext that will either redirect you to the workspace page if you are an admin of said workspace, or just a text displaying the name of the workspace you are a member of.
7. If the room for workspace is a custom user-created room, try viewing it as a guest and confirm that the Join PromotedAction does show and work properly in the PromotedActionsBar.

IOU / Expense Reports:

1. Create a new IOU / Expense report.
2. If the expense is deleteable, the delete button should appear and display the confirmation modal through which you can delete the selected expense.
3. On any of the expenses there should be the PromotedActionsBar displaying the correct values, which are Pin and Share actions, Hold if the expense is available for being held.
4. Please test deleting the expenses throughoutly, check whether all the cases that should be deletable are in fact able to be deleted and this functionality has been revamped properly.

Tasks:

1. Create a new task.
2. If the task isn't completed, the delete button should be displayed after which you will have to confirm the action with a confirmation modal. If you have completed the task, there should be a Mark as incomplete button which will cancel the completion status for the task.
3. PromotedActionsBar should display the pin and share actions.

Refer to the PromotedActions table from Test steps to check whether every PromotedAction does properly display in each case specified in said table above.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android.Native.mov

Android: mWeb Chrome

Android.Chrome.mov

iOS: Native

IOS.Native.mov

iOS: mWeb Safari

IOS.Safari.mov

MacOS: Chrome / Safari

Chrome.mov

MacOS: Desktop

Desktop.mov

[cdOut]

As an update, during the creation of test steps I've encountered a case that isn't yet handled. I'm currently adding it into the page after which this PR will be able to be moved to review.

[cdOut]

@grgia I've added the CONST suggestion and merged with newest main, there was a problem with action.originalMessage getting deprecated so I swapped it with the updated ReportActionsUtils.getOriginalMessage().

You could retest whether after the expense deletion you get redirected to the correct page, I've tested it myself and it should be good. After that it is ready to be merged.

[grgia]

Code changes LGTM

[grgia]

Triggering a test build to QA

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/43251/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/43251/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/43251/NewExpensify.dmg	https://43251.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[grgia]

Tests well! Looks great. I'm going to go ahead and

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/grgia in version: 9.0.1-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[kavimuru]

@grgia @ikevin127 It would be great if you could help with the following about this PR.

• How to invite as a guest to workspace chat , user created workspace room and to IOU expense? ( By mentioning the user?)

[OSBotify]

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[jayeshmangwani]

Here, we are checking ReportUtils.canAddOrDeleteTransactions(moneyRequestReport) and ReportUtils.isTrackExpenseReport(transactionThreadReport) to determine if we should show the delete request button.
This fails for self-DM track because, for self-DM track, transactionThreadReport is undefined, which causes canAddOrDeleteTransactions to return false. This caused this Issue #44334.

We have handled the issue by adding a check for isTrackExpenseReport and isSelfDM for canDeleteRequest value. More details can be found in the selected proposal #44334 (comment)

[fedirjh]

Coming from #45346, If the report name cannot be edited, we should center it. We fixed that by adding titleContainerStyle prop with styles.alignItemsCenter style to MenuItemWithTopDescription in nameSectionGroupWorkspace.

[allgandalf]

We missed the canActionTask check here, which caused #49408

[alitoshmatov]

There is a race condition between deleting a transaction and navigating back. This results in brief moment where transaction page is still open but there is no data(showing Deleted transaction. This is primarily noticeable in slower devices. #45576