-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: marker is not clickable on android #4774
Conversation
@parasharrajat Thanks for testing this on Android, but can you please also test on other platforms to make sure no regressions occurred elsewhere? 👍 (I'll do the same) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well on Desktop, Android, Web.
I have no code review comments 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only 2 tiny documentation comments that are NAB 👍 - back to you @Julesssss !
src/pages/home/report/MarkerBadge/MarkerBadgeContainer/MarkerBadgeContainerPropTypes.js
Outdated
Show resolved
Hide resolved
src/pages/home/report/MarkerBadge/MarkerBadgeContainer/MarkerBadgeContainerPropTypes.js
Outdated
Show resolved
Hide resolved
574918e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 will merge once tests finish
Note: I tested on iOS & mWeb, things look good (so I checked them off the list in the OP) |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Fix: marker is not clickable on android (cherry picked from commit 5502f86)
🚀 Cherry-picked to staging by @roryabraham in version: 1.0.86-7 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
This has been deployed to production and is now subject to a 7-day regression period. |
🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀
|
This has been deployed to production and is now subject to a 7-day regression period. |
🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀
|
This has been deployed to production and is now subject to a 7-day regression period. |
Details
Changed the design for MarkerBadge as touches are not propagated in Android outside the parent which was blocking the click on the half of the Badge.
Fixed Issues
$ #4716
Tests | QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android
and-marker.mp4