Fix "Add custom segment or record" image appears briefly after adding first segment #48297

CyberAndrii · 2024-08-29T20:32:32Z

Details

Fixed Issues

Tests

If you don't have NetSuite credentials, disable validation as follows

diff --git a/src/pages/workspace/accounting/PolicyAccountingPage.tsx b/src/pages/workspace/accounting/PolicyAccountingPage.tsx
index 11c47a21f2e..869dd8cf600 100644
--- a/src/pages/workspace/accounting/PolicyAccountingPage.tsx
+++ b/src/pages/workspace/accounting/PolicyAccountingPage.tsx
@@ -231,7 +231,7 @@ function PolicyAccountingPage({policy}: PolicyAccountingPageProps) {
             return [];
         }
         const shouldShowSynchronizationError = !!synchronizationError;
-        const shouldHideConfigurationOptions = isConnectionUnverified(policy, connectedIntegration);
+        const shouldHideConfigurationOptions = false;
         const integrationData = getAccountingIntegrationData(connectedIntegration, policyID, translate, policy);
         const iconProps = integrationData?.icon ? {icon: integrationData.icon, iconType: CONST.ICON_TYPE_AVATAR} : {};

Open the app
Log in or create a new account
Open Account settings > Workspaces
Create a new workspace
Enable "Accounting" on the "More features" page
Navigate to "Accounting"
Connect to NetSuite and upgrade the workspace to Control when asked
Wait for the sync to finish
Navigate to Accounting - Import - Custom segments/records
Click on the "Add custom segment/record" button
Add a Custom record with any random data.
Verify that the "Add custom segment or record" image did not appear after clicking the "Confirm" button on the last step.

Offline tests

QA Steps

Open the app
Log in or create a new account
Open Account settings > Workspaces
Create a new workspace
Enable "Accounting" on the "More features" page
Navigate to "Accounting"
Connect to NetSuite and upgrade the workspace to Control when asked
Wait for the sync to finish
Navigate to Accounting - Import - Custom segments/records
Click on the "Add custom segment/record" button
Add a Custom record with any random data
Verify that the "Add custom segment or record" image did not appear after clicking the "Confirm" button on the last step.

PR Author Checklist

Screenshots/Videos

Android: Native

47501.android.native.webm

Android: mWeb Chrome

47501.android.mWeb.webm

iOS: Native

47501.ios.native.mp4

iOS: mWeb Safari

47501.ios.mWeb.mp4

MacOS: Chrome / Safari

47501.macos.safari.mov

MacOS: Desktop

47501.macos.desktop.mov

melvin-bot · 2024-08-29T20:32:37Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

CyberAndrii · 2024-08-29T20:50:45Z

@mollfpr PR is ready for review

.../accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteImportAddCustomListPage.tsx

mollfpr · 2024-09-05T08:27:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

48297.Android.mp4

Android: mWeb Chrome

48297.mWeb-Chrome.mp4

iOS: Native

48297.iOS.mov

iOS: mWeb Safari

48297.mWeb-Safari.mov

MacOS: Chrome / Safari

48297.Web.mp4

MacOS: Desktop

48297.Desktop.mp4

mollfpr

LGTM 👍

shubham1206agra · 2024-09-10T12:00:07Z

...counting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteImportAddCustomSegmentPage.tsx

@@ -40,7 +40,9 @@ function NetSuiteImportAddCustomSegmentPage({policy}: WithPolicyConnectionsProps
    const customSegments = useMemo(() => config?.syncOptions?.customSegments ?? [], [config?.syncOptions]);

    const handleFinishStep = useCallback(() => {
-        Navigation.goBack(ROUTES.POLICY_ACCOUNTING_NETSUITE_IMPORT_CUSTOM_FIELD_MAPPING.getRoute(policyID, CONST.NETSUITE_CONFIG.IMPORT_CUSTOM_FIELDS.CUSTOM_SEGMENTS));
+        InteractionManager.runAfterInteractions(() => {


@CyberAndrii Why was this logic added here?

#48297 (comment). Delays the navigation until optimistic onyx data is applied and the page is re-rendered

CyberAndrii requested a review from a team as a code owner August 29, 2024 20:32

melvin-bot bot requested review from mollfpr and removed request for a team August 29, 2024 20:32

CyberAndrii force-pushed the 47501-fix-'add-custom-segment-or-record'-page-appears-briefly-after-adding-the-first-segment branch from fd175d3 to 78f8f7f Compare August 31, 2024 19:10

CyberAndrii added 3 commits August 31, 2024 22:12

Replace withOnyx with useOnyx

e56d529

Delay navigation to run after interactions

84ed1a8

Check if NetSuite options is not null

7810fdc

CyberAndrii force-pushed the 47501-fix-'add-custom-segment-or-record'-page-appears-briefly-after-adding-the-first-segment branch from 78f8f7f to 7810fdc Compare August 31, 2024 19:12

mollfpr reviewed Sep 2, 2024

View reviewed changes

.../accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteImportAddCustomListPage.tsx Show resolved Hide resolved

mollfpr approved these changes Sep 5, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath September 5, 2024 17:27

puneetlath approved these changes Sep 9, 2024

View reviewed changes

puneetlath merged commit 89b9226 into Expensify:main Sep 9, 2024
16 of 19 checks passed

CyberAndrii deleted the 47501-fix-'add-custom-segment-or-record'-page-appears-briefly-after-adding-the-first-segment branch September 9, 2024 16:16

VickyStash mentioned this pull request Sep 10, 2024

[HOLD for payment 2024-09-18] [$50] Android – Workspace settings–Hmm page appears briefly when open just invited member settings #48867

Closed

6 tasks

shubham1206agra mentioned this pull request Sep 10, 2024

New page structure for export Sage Intacct #48764

Merged

49 tasks

shubham1206agra reviewed Sep 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix "Add custom segment or record" image appears briefly after adding first segment #48297

Fix "Add custom segment or record" image appears briefly after adding first segment #48297

CyberAndrii commented Aug 29, 2024 •

edited

Loading

melvin-bot bot commented Aug 29, 2024

CyberAndrii commented Aug 29, 2024

mollfpr commented Sep 5, 2024 •

edited

Loading

mollfpr left a comment

shubham1206agra Sep 10, 2024

CyberAndrii Sep 10, 2024

Fix "Add custom segment or record" image appears briefly after adding first segment #48297

Fix "Add custom segment or record" image appears briefly after adding first segment #48297

Conversation

CyberAndrii commented Aug 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 29, 2024

CyberAndrii commented Aug 29, 2024

mollfpr commented Sep 5, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

shubham1206agra Sep 10, 2024

Choose a reason for hiding this comment

CyberAndrii Sep 10, 2024

Choose a reason for hiding this comment

CyberAndrii commented Aug 29, 2024 •

edited

Loading

mollfpr commented Sep 5, 2024 •

edited

Loading