fix: attachment menu position #52021

teneeto · 2024-11-05T10:11:42Z

Details

This PR fixes the contextMenuActions position i.e the report actions attachment menu position.

Fixed Issues

$ #50818
PROPOSAL: #50818

Tests

Login into any account
Navigate to any 1:1 DM
Send any video/image attachment
Send another video/image attachment
Hover over the first image/video attachment and click on the "..." button
While the context menu of the first attachment is still open, Hover over the second image/video attachment and click on the "..." button.

Verify that no errors appear in the JS console

Offline tests

Login into any account
Navigate to any 1:1 DM
Send any video/image attachment
Send another video/image attachment
Hover over the first image/video attachment and click on the "..." button
While the context menu of the first attachment is still open, Hover over the second image/video attachment and click on the "..." button.

QA Steps

Login into any account
Navigate to any 1:1 DM
Send any video/image attachment
Send another video/image attachment
Hover over the first image/video attachment and click on the "..." button
While the context menu of the first attachment is still open, Hover over the second image/video attachment and click on the "..." button.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-11-14.at.05.51.47.mov

Android: Native

iOS: Native

iOS: mWeb Safari

MacOS: Desktop

melvin-bot · 2024-11-06T07:51:41Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…tachment-modal-position

rojiphil · 2024-11-07T20:11:13Z

src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

@@ -64,8 +64,7 @@ function hideContextMenu(shouldDelay?: boolean, onHideCallback = () => {}) {
        return;
    }
    if (!shouldDelay) {
-        contextMenuRef.current.hideContextMenu(onHideCallback);
-
+        onHideCallback();


@teneeto Thanks for the PR.
Can you please share some information on how this change helps in resolving the issue?
Also, this code has not been changed for quite some time. So, I am curious to know what recent changes could have triggered this issue.

rojiphil · 2024-11-07T20:32:43Z

@teneeto Strange. I can reproduce the problem with the changes in the PR. Here is a test video demonstrating the same. Am I missing something here?

52021-issue-fix-001.mp4

teneeto · 2024-11-08T09:35:42Z

Hi @rojiphil, having a look

teneeto · 2024-11-08T09:46:42Z

O I see, I Solved for a completely different bug I guess. Let me do a recording to share more info on what I did. I possibly tested for the wrong issue.

…tachment-modal-position

teneeto · 2024-11-13T07:30:08Z

@rojiphil, so we have this situation whereby once a context menu is already open and you immediately try opening another from any report action item and then try to click on the same action again, the context menu looses it's position and this because the context is called twice. I initially thought I was solving our current issue of focus, however, The current solution solves that issue i just mentioned as described in the record below.

Screen.Recording.2024-11-13.at.08.23.53.mov

teneeto · 2024-11-13T07:31:37Z

I'm still trying to wrap up for the videoplayer context menu. Couldn't complete it yesterday, but giving it a try again today.

teneeto · 2024-11-14T04:43:48Z

and for that i intend to agree with Shahinyan11's earlier proposal

…tachment-modal-position

teneeto · 2024-11-14T15:00:04Z

@rojiphil can you check again?

rojiphil · 2024-11-15T04:58:51Z

can you check again?

I just checked again and my initial assessment is that it is fixed now. I will continue with the review and again update later today.

rojiphil · 2024-11-15T16:10:27Z

I am not able to test the play of a video attachment on Web Safari platform. But I don't think our PR is the cause of this. I have raised an issue though in slack here. Once there is clarity on this issue, I will continue with the checklist.

…tachment-modal-position

rojiphil · 2024-11-18T19:04:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Safari

52021-web-safari-001.mp4

MacOS: Chrome

52021-web-chrome-001.mp4

MacOS: Desktop

52121-desktop-001.mp4

iOS: mWeb Safari

Not applicable for this issue

Android: Native

Not applicable for this issue

Android: mWeb Chrome

Not applicable for this issue

iOS: Native

Not applicable for this issue

rojiphil

Thanks for the PR @teneeto . Just a NAB request though to add the test case specific to the steps 6,7,8 as mentioned in OP steps for this issue here

@thienlnam Changes LGTM and works well too.
All yours for review. Thanks.

melvin-bot · 2024-11-18T19:14:52Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #50818 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2024-11-18T20:11:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-19T01:22:08Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.64-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

j-piasecki · 2024-11-19T09:39:45Z

src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

@@ -64,8 +64,7 @@ function hideContextMenu(shouldDelay?: boolean, onHideCallback = () => {}) {
        return;
    }
    if (!shouldDelay) {
-        contextMenuRef.current.hideContextMenu(onHideCallback);
-
+        onHideCallback();


This change causes the context menu to stay open on mobile.

Screen.Recording.2024-11-19.at.10.36.51.mov

Thanks @j-piasecki for pointing this out.
@teneeto Let us raise another PR to fix this. I think we can revert this line to the original as it was not required to fix the issue at hand here. What do you think?

github-actions · 2024-11-21T01:16:05Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.64-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

teneeto added 4 commits November 5, 2024 11:08

fix window dimensions

df70673

fix lint

9e37309

call onHideCallback directly.

62cd803

undo windowDimensions changes

36a0550

teneeto marked this pull request as ready for review November 6, 2024 07:51

teneeto requested a review from a team as a code owner November 6, 2024 07:51

melvin-bot bot requested review from rojiphil and removed request for a team November 6, 2024 07:51

teneeto added 2 commits November 6, 2024 09:40

Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…

f819839

…tachment-modal-position

Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…

f6d850e

…tachment-modal-position

rojiphil reviewed Nov 7, 2024

View reviewed changes

Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…

6afa43b

…tachment-modal-position

remove useless didScreenReturnToOriginalSize

f3d0eba

teneeto added 5 commits November 14, 2024 05:49

remove useless didScreenReturnToOriginalSize

91d791b

fix context menu double call

ec64bca

Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…

3883b5e

…tachment-modal-position

Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…

c4da175

…tachment-modal-position

Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…

f12f6bc

…tachment-modal-position

Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…

52985d0

…tachment-modal-position

rojiphil approved these changes Nov 18, 2024

View reviewed changes

thienlnam approved these changes Nov 18, 2024

View reviewed changes

thienlnam merged commit 4829ac9 into Expensify:main Nov 18, 2024
18 checks passed

github-actions bot mentioned this pull request Nov 19, 2024

Deploy Checklist: New Expensify 2024-11-19 #52733

Closed

54 tasks

j-piasecki reviewed Nov 19, 2024

View reviewed changes

IuliiaHerets mentioned this pull request Nov 19, 2024

[HOLD for payment 2024-11-29] [HOLD for payment 2024-11-28] [$250] Attachment- Hmm it's not here page occur when expanding attached video #52747

Closed

8 tasks

nkdengineer mentioned this pull request Nov 19, 2024

[HOLD for payment 2024-11-29] mWeb - Chat -Contextual menu does not close on selecting delete, edit comment & reply in thread opt #52744

Closed

8 tasks

melvin-bot bot mentioned this pull request Nov 21, 2024

[HOLD for payment 2024-11-28] [$250] Attachment - The position of the attachment "Menu" modal is incorrect #50818

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: attachment menu position #52021

fix: attachment menu position #52021

teneeto commented Nov 5, 2024 •

edited

Loading

melvin-bot bot commented Nov 6, 2024

rojiphil Nov 7, 2024

rojiphil commented Nov 7, 2024

teneeto commented Nov 8, 2024

teneeto commented Nov 8, 2024

teneeto commented Nov 13, 2024 •

edited

Loading

teneeto commented Nov 13, 2024

teneeto commented Nov 14, 2024

teneeto commented Nov 14, 2024

rojiphil commented Nov 15, 2024

rojiphil commented Nov 15, 2024

rojiphil commented Nov 18, 2024

rojiphil left a comment •

edited

Loading

melvin-bot bot commented Nov 18, 2024

OSBotify commented Nov 18, 2024

github-actions bot commented Nov 19, 2024

j-piasecki Nov 19, 2024

rojiphil Nov 19, 2024

github-actions bot commented Nov 21, 2024

fix: attachment menu position #52021

fix: attachment menu position #52021

Conversation

teneeto commented Nov 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 6, 2024

rojiphil Nov 7, 2024

Choose a reason for hiding this comment

rojiphil commented Nov 7, 2024

teneeto commented Nov 8, 2024

teneeto commented Nov 8, 2024

teneeto commented Nov 13, 2024 • edited Loading

teneeto commented Nov 13, 2024

teneeto commented Nov 14, 2024

teneeto commented Nov 14, 2024

rojiphil commented Nov 15, 2024

rojiphil commented Nov 15, 2024

rojiphil commented Nov 18, 2024

Reviewer Checklist

Screenshots/Videos

rojiphil left a comment • edited Loading

Choose a reason for hiding this comment

melvin-bot bot commented Nov 18, 2024

OSBotify commented Nov 18, 2024

github-actions bot commented Nov 19, 2024

j-piasecki Nov 19, 2024

Choose a reason for hiding this comment

rojiphil Nov 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 21, 2024

teneeto commented Nov 5, 2024 •

edited

Loading

teneeto commented Nov 13, 2024 •

edited

Loading

rojiphil left a comment •

edited

Loading