Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attachment menu position #52021

Merged
merged 14 commits into from
Nov 18, 2024
Merged

fix: attachment menu position #52021

Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
df70673
fix window dimensions
teneeto Nov 5, 2024
9e37309
fix lint
teneeto Nov 5, 2024
62cd803
call onHideCallback directly.
teneeto Nov 6, 2024
36a0550
undo windowDimensions changes
teneeto Nov 6, 2024
f819839
Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…
teneeto Nov 6, 2024
f6d850e
Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…
teneeto Nov 7, 2024
6afa43b
Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…
teneeto Nov 13, 2024
f3d0eba
remove useless didScreenReturnToOriginalSize
teneeto Nov 14, 2024
91d791b
remove useless didScreenReturnToOriginalSize
teneeto Nov 14, 2024
ec64bca
fix context menu double call
teneeto Nov 14, 2024
3883b5e
Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…
teneeto Nov 14, 2024
c4da175
Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…
teneeto Nov 14, 2024
f12f6bc
Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…
teneeto Nov 14, 2024
52985d0
Merge branch 'main' of github.com:teneeto/Expensify into fix/50818/at…
teneeto Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/pages/home/report/ContextMenu/ReportActionContextMenu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ function hideContextMenu(shouldDelay?: boolean, onHideCallback = () => {}) {
return;
}
if (!shouldDelay) {
contextMenuRef.current.hideContextMenu(onHideCallback);

onHideCallback();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teneeto Thanks for the PR.
Can you please share some information on how this change helps in resolving the issue?
Also, this code has not been changed for quite some time. So, I am curious to know what recent changes could have triggered this issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change causes the context menu to stay open on mobile.

Screen.Recording.2024-11-19.at.10.36.51.mov

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @j-piasecki for pointing this out.
@teneeto Let us raise another PR to fix this. I think we can revert this line to the original as it was not required to fix the issue at hand here. What do you think?

return;
}

Expand Down
Loading