-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Pay an Expense help article and update the header on the existing Pay an Invoice article #52520
Conversation
Related GH- Expensify/Expensify#438175 Creating a Pay-an-Expense article
Updating the heading of "to pay an invoice," to "Pay and invoice" so the formatting is the same as other articles
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://47f2a87e.helpdot.pages.dev ⚡️ |
there's a formatting error - making a change to try and fix it.
Just fixing some styling
Sorry just a few tweaks to the wording based on discussion in the https://docs.google.com/document/d/1R34ySbXKzI05zXyOu8b7qe4uiaCfYW9M9pA8b8umhF4/edit?tab=t.0.
Okay! I did a review and these look good. Thanks @youssef-lr! |
docs/articles/new-expensify/expenses-&-payments/Pay-an-expense.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Fixed a small typo.
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.65-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.65-5 🚀
|
Explanation of Change
Related GH: https://github.com/Expensify/Expensify/issues/438175
This pay an expense article has been created to outline the new steps related to our "Improve how we notify users of iou/expense report submissions" project
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.