[No QA] Update force upgrade modal #52703

war-in · 2024-11-18T14:35:46Z

Explanation of Change

Fixed Issues

$ #52276
PROPOSAL:

Tests

We're not able to test this change without mocking some local variables

Offline tests

QA Steps

Internal testing only!

Simply check that the apps are not blocked by the upgrade modal

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

war-in · 2024-11-18T15:06:41Z

cc @staszekscp

war-in · 2024-11-18T15:55:40Z

I checked the changes locally and it worked but as @Julesssss said we're not able to test it reliably without code changes

AndrewGable · 2024-11-18T22:15:31Z

This doesn't show the upgrade modal on Web or Desktop, right?

Julesssss

~~Hey @war-in, @AndrewGable createdand deployed a BETA that we can use here to safety test on production: hybridForcedMigration.~~

Actually sorry you can ignore that. I'll be handling on the backend entirely 😄

war-in · 2024-11-19T12:26:38Z

This doesn't show the upgrade modal on Web or Desktop, right?

@AndrewGable there are no changes for web or desktop so it'll work like previously

Julesssss

@war-in can this be put into full review?

melvin-bot · 2024-11-19T15:54:43Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

war-in · 2024-11-19T15:54:54Z

@Julesssss done!

github-actions · 2024-11-19T15:56:32Z

🚧 @Julesssss has triggered a test build. You can view the workflow run here.

c3024 · 2024-11-19T15:57:53Z

@Julesssss

Does this need a C+ review?

github-actions · 2024-11-19T16:21:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52703/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52703/NewExpensify.dmg	https://52703.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Julesssss · 2024-11-19T16:32:09Z

Hi @c3024, I don't think so in this case as we're keeping a close eye on it internally.

Julesssss · 2024-11-19T16:48:18Z

@AndrewGable I think we're good here

trjExpensify

Coming from the thread, copy edit for this one.

…g-prod-env-upgrade-modal

war-in · 2024-11-20T09:38:24Z

@trjExpensify done

src/pages/ErrorPage/UpdateRequiredView.tsx

Julesssss · 2024-11-20T14:13:43Z

Lets test against the beta. Looks good to me 👍

trjExpensify

Modal looks good to me!

src/languages/es.ts

AndrewGable · 2024-11-20T20:46:33Z

FYI conflicts

Co-authored-by: Tom Rhys Jones <[email protected]>

…upgrade-modal # Conflicts: # src/languages/es.ts

war-in · 2024-11-21T10:51:38Z

Conflicts resolved!

OSBotify · 2024-11-21T12:31:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-22T20:31:54Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Julesssss · 2024-11-25T11:51:53Z

Checked off App deploy internalQA, we need some more PRs to be deployed first.

github-actions · 2024-11-26T16:13:19Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.66-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

update force upgrade modal

1c77db7

war-in changed the title ~~Update force upgrade modal~~ [No QA] Update force upgrade modal Nov 18, 2024

Julesssss added the InternalQA This pull request required internal QA label Nov 18, 2024

Julesssss approved these changes Nov 18, 2024

View reviewed changes

Julesssss reviewed Nov 19, 2024

View reviewed changes

war-in marked this pull request as ready for review November 19, 2024 15:54

war-in requested a review from a team as a code owner November 19, 2024 15:54

melvin-bot bot requested review from c3024 and removed request for a team November 19, 2024 15:54

Julesssss added the Ready To Build label Nov 19, 2024

Julesssss previously approved these changes Nov 19, 2024

View reviewed changes

Julesssss removed the request for review from c3024 November 19, 2024 16:31

trjExpensify self-requested a review November 19, 2024 20:40

trjExpensify requested changes Nov 19, 2024

View reviewed changes

war-in added 2 commits November 20, 2024 10:25

Merge branch 'refs/heads/main' into war-in/distinguish-between-stagin…

61d1a32

…g-prod-env-upgrade-modal

update text

5d54677

war-in dismissed Julesssss’s stale review via 5d54677 November 20, 2024 09:37

Julesssss reviewed Nov 20, 2024

View reviewed changes

src/pages/ErrorPage/UpdateRequiredView.tsx Outdated Show resolved Hide resolved

war-in and others added 2 commits November 20, 2024 11:07

show updated text for standalone new app on production

fab1c5a

Update es.ts

ff9dc0b

Julesssss previously approved these changes Nov 20, 2024

View reviewed changes

AndrewGable requested a review from trjExpensify November 20, 2024 17:47

trjExpensify previously approved these changes Nov 20, 2024

View reviewed changes

trjExpensify reviewed Nov 20, 2024

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

war-in dismissed stale reviews from trjExpensify and Julesssss via c24597d November 21, 2024 10:48

war-in and others added 2 commits November 21, 2024 11:48

Update src/languages/es.ts

c24597d

Co-authored-by: Tom Rhys Jones <[email protected]>

Merge branch 'main' into war-in/distinguish-between-staging-prod-env-…

c4da656

…upgrade-modal # Conflicts: # src/languages/es.ts

fix lint and prettier

ef4f0a2

Julesssss approved these changes Nov 21, 2024

View reviewed changes

Julesssss merged commit 0029614 into Expensify:main Nov 21, 2024
15 of 16 checks passed

github-actions bot mentioned this pull request Nov 22, 2024

Deploy Checklist: New Expensify 2024-11-22 #52978

Closed

75 tasks

melvin-bot bot mentioned this pull request Nov 26, 2024

[HybridApp] Update the force upgrade modal to distinguish between prod and staging environments. #52276

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Update force upgrade modal #52703

[No QA] Update force upgrade modal #52703

war-in commented Nov 18, 2024 •

edited by Julesssss

Loading

war-in commented Nov 18, 2024

war-in commented Nov 18, 2024 •

edited

Loading

AndrewGable commented Nov 18, 2024

Julesssss left a comment •

edited

Loading

war-in commented Nov 19, 2024

Julesssss left a comment

melvin-bot bot commented Nov 19, 2024

war-in commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

c3024 commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

Julesssss commented Nov 19, 2024

Julesssss commented Nov 19, 2024

trjExpensify left a comment

war-in commented Nov 20, 2024

Julesssss commented Nov 20, 2024

trjExpensify left a comment

AndrewGable commented Nov 20, 2024

war-in commented Nov 21, 2024

OSBotify commented Nov 21, 2024

github-actions bot commented Nov 22, 2024

Julesssss commented Nov 25, 2024

github-actions bot commented Nov 26, 2024

[No QA] Update force upgrade modal #52703

[No QA] Update force upgrade modal #52703

Conversation

war-in commented Nov 18, 2024 • edited by Julesssss Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

war-in commented Nov 18, 2024

war-in commented Nov 18, 2024 • edited Loading

AndrewGable commented Nov 18, 2024

Julesssss left a comment • edited Loading

Choose a reason for hiding this comment

war-in commented Nov 19, 2024

Julesssss left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 19, 2024

war-in commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

c3024 commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

Julesssss commented Nov 19, 2024

Julesssss commented Nov 19, 2024

trjExpensify left a comment

Choose a reason for hiding this comment

war-in commented Nov 20, 2024

Julesssss commented Nov 20, 2024

trjExpensify left a comment

Choose a reason for hiding this comment

AndrewGable commented Nov 20, 2024

war-in commented Nov 21, 2024

OSBotify commented Nov 21, 2024

github-actions bot commented Nov 22, 2024

Julesssss commented Nov 25, 2024

github-actions bot commented Nov 26, 2024

war-in commented Nov 18, 2024 •

edited by Julesssss

Loading

war-in commented Nov 18, 2024 •

edited

Loading

Julesssss left a comment •

edited

Loading