Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize state updates done in the commit hook #550

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

j-piasecki
Copy link
Collaborator

Details

This PR reduces the amount of times the state is cloned in the commit hook. If the state already has expected values, there's no need to clone it again (there's pointer equality in the logic responsible for passing the state updates in RN).

Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@tomekzaw tomekzaw merged commit 194e952 into main Nov 21, 2024
5 checks passed
@tomekzaw tomekzaw deleted the @jpiasecki/optimize-commit-hook branch November 21, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants