Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize state updates done in the commit hook #550

Merged
merged 2 commits into from
Nov 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions android/src/main/new_arch/MarkdownCommitHook.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -107,26 +107,31 @@ RootShadowNode::Unshared MarkdownCommitHook::shadowTreeWillCommit(
rootNode = rootNode->cloneTree(
nodes.textInput->getFamily(),
[this, &stateData, &textInputState, &nodes](ShadowNode const &node) {
auto newStateData =
std::make_shared<AndroidTextInputState>(stateData);
// force measurement of a map buffer
newStateData->cachedAttributedStringId = 0;

// setting -1 as the event counter makes sure that the update will be ignored by the java
// part of the code, which is what we want as we don't change the attributed string here
if (previousEventCount_.contains(nodes.textInput->getTag()) &&
std::shared_ptr<ShadowNode> newNode = nullptr;

if (stateData.cachedAttributedStringId != 0) {
auto newStateData =
std::make_shared<AndroidTextInputState>(stateData);

// force measurement of a map buffer
newStateData->cachedAttributedStringId = 0;

// setting -1 as the event counter makes sure that the update will be ignored by the java
// part of the code, which is what we want as we don't change the attributed string here
if (previousEventCount_.contains(nodes.textInput->getTag()) &&
previousEventCount_[nodes.textInput->getTag()] == stateData.mostRecentEventCount) {
newStateData->mostRecentEventCount = -1;
} else {
} else {
previousEventCount_[nodes.textInput->getTag()] = stateData.mostRecentEventCount;
}
}

auto newState = std::make_shared<const ConcreteState<AndroidTextInputState>>(
newStateData, textInputState);

// clone the text input with the new state
auto newNode = node.clone({
.state =
std::make_shared<const ConcreteState<AndroidTextInputState>>(
newStateData, textInputState),
});
newNode = node.clone({ .state = newState });
} else {
newNode = node.clone({});
}

const auto currentDecoratorProps =
nodes.decorator->getProps()->rawProps["markdownStyle"];
Expand Down
Loading