Fix prop dependent withOnyx updates + add test #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 16, 2021
Gonals
reviewed
Aug 17, 2021
| @@ -87,20 +87,20 @@ export default function (mapOnyxToState) { | |||
| * @param {*} val | |||
| */ | |||
| setInitialState(statePropertyName, val) { | |||
| if (!this.state.loading) { | |||
There was a problem hiding this comment.
Mostly out of curiosity: why are we reversing this if?
There was a problem hiding this comment.
The logic has changed from what we had before which was incorrect.
There was a problem hiding this comment.
We don't need to invert the logic though it's just how I did it. Updated so this is unchanged but the logic is the same.
|
Merging since this will remove the hold on a deploy blocker fix. Sorry @Gonals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
cc @kidroca See this comment here -> #97 (comment)
We've caused a regression with prop dependent updates.
Related Issues
There are probably some if we've already started regressions.
Automated Tests
A new test to make sure withOnyx always works with prop dependent keys was added.
Linked PRs
Expensify/App#4676