Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update withOnyx to fix prop dependent key updates #4676

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Update withOnyx to fix prop dependent key updates #4676

merged 4 commits into from
Aug 17, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Aug 16, 2021 •
edited
Loading

Details

See linked Onyx PR: Expensify/react-native-onyx#98

Fixed Issues

Expensify/react-native-onyx#97 (comment)

Tests

Automated tests in react-native-onyx

QA Steps

No specific QA besides regressions

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Aug 16, 2021
@marcaaron marcaaron changed the title [HOLD] [CP Staging] Update withOnyx to fix prop dependent key updates [HOLD] Update withOnyx to fix prop dependent key updates Aug 16, 2021
This was referenced Aug 16, 2021
Merged
Merged
@marcaaron marcaaron requested a review from Gonals August 16, 2021 17:42
@marcaaron marcaaron marked this pull request as ready for review August 16, 2021 17:42
@marcaaron marcaaron requested a review from a team as a code owner August 16, 2021 17:42
@marcaaron marcaaron removed the request for review from a team August 16, 2021 17:42
@marcaaron
Copy link
Contributor Author

Heads up this may need to be a CP to staging depending on when this other PR hits staging -> #4610

@luacmartins luacmartins mentioned this pull request Aug 17, 2021
Closed
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@marcaaron marcaaron changed the title [HOLD] Update withOnyx to fix prop dependent key updates Update withOnyx to fix prop dependent key updates Aug 17, 2021
luacmartins
luacmartins approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luacmartins
Copy link
Contributor

@marcaaron feel free to self-merge once tests are done.

@marcaaron
Copy link
Contributor Author

Did some quick tests on web and seems like chat switching is fixed up now. Going to merge without the E2E passing so that we can avoid further confusion.

@marcaaron marcaaron merged commit a27fbfc into main Aug 17, 2021
@marcaaron marcaaron deleted the marcaaron-updateOnyx2 branch August 17, 2021 23:35
@marcaaron
Copy link
Contributor Author

Also tested iOS and it builds fine - which is all the E2E test does.

github-actions bot pushed a commit that referenced this pull request Aug 17, 2021
@marcaaron
Merge pull request #4676 from Expensify/marcaaron-updateOnyx2
774a28d 
Update withOnyx to fix prop dependent key updates

(cherry picked from commit a27fbfc)
@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Merged
@marcaaron marcaaron mentioned this pull request Aug 17, 2021
Closed
@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @marcaaron in version: 1.0.86-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 25, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

This was referenced Sep 1, 2021
Closed
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luacmartins luacmartins luacmartins approved these changes

@Gonals Gonals Awaiting requested review from Gonals

@sketchydroide sketchydroide Awaiting requested review from sketchydroide

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @luacmartins @OSBotify