Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tracker compatibility for version 41 #63

Merged
merged 9 commits into from
Jan 14, 2025

Conversation

eperedo
Copy link
Contributor

@eperedo eperedo commented Jan 8, 2025

📌 References

📝 Implementation

  • There's a new response schema in v41 for tracker/events endpoints:

Before v41 records are included in property instances

{
  "page": 1,
  "total": 0,
  "pageCount": 1,
  "pageSize": 50,
  "instances": [
    
  ]
}

In v41 there's a new property trackedEntities

{
  "page": 2,
  "pageSize": 1000000,
  "total": 1,
  "pageCount": 1,
  "trackedEntities": [
    
  ]
}

Similar for the /tracker/events endpoints from instances to events

  • Include dataSet parameter for outlier endpoint (/api/outlierDetection) since now is mandatory

📹 Screenshots/Screen capture

🔥 Notes to the tester

#8697ct73j

@eperedo eperedo requested a review from Ramon-Jimenez January 8, 2025 17:57
@ifoche
Copy link
Member

ifoche commented Jan 8, 2025

Task linked: CU-8697ct73j Support for 2.41

Copy link
Contributor

@Ramon-Jimenez Ramon-Jimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eperedo I am still getting an error, although a different one:

image

Also, although there are supposed to be some analysis already present, none of them are being listed.

Thanks for checking

@eperedo
Copy link
Contributor Author

eperedo commented Jan 10, 2025

@eperedo I am still getting an error, although a different one:

image

Also, although there are supposed to be some analysis already present, none of them are being listed.

Thanks for checking

I've fixed the error message. I cannot replicate this "Also, although there are supposed to be some analysis already present, none of them are being listed." Are you using the docker v41? Because there are no analysis in that instance. I can see all the analysis in the dev environment.

@eperedo eperedo requested a review from Ramon-Jimenez January 10, 2025 14:27
Copy link
Contributor

@Ramon-Jimenez Ramon-Jimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all good @eperedo

@Ramon-Jimenez Ramon-Jimenez merged commit a56853c into development Jan 14, 2025
1 check passed
@Ramon-Jimenez Ramon-Jimenez deleted the feature/support-v41 branch January 14, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants