feat: Create basic table component #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 26, 2024 17:35
…nd-layout' into feature/create-basic-table-component
delemaf
changed the title
added 5 commits
June 28, 2024 09:40
9sneha-n
requested changes
Jul 1, 2024
| } | ||
|
|
||
| export const BasicTable: React.FC<BasicTableProps> = React.memo( | ||
| ({ columns, rows, onChange = () => {}, showRowIndex = false }) => { |
There was a problem hiding this comment.
should we have a default value for onChange(), or should we check if(onChange()) before every call?
There was a problem hiding this comment.
I'm not sure every table will need onChange so I left default value but I don't know what's best
src/webapp/pages/incident-action-plan/IncidentActionPlanPage.tsx
Outdated
Show resolved
Hide resolved
anagperal
reviewed
Jul 1, 2024
anagperal
reviewed
Jul 1, 2024
anagperal
reviewed
Jul 1, 2024
Base automatically changed from
feature/create-main-components-and-layout
to
development
July 8, 2024 09:45
anagperal
reviewed
Jul 9, 2024
|
@delemaf now the table looks like this:
it's ok? |
|
Header background color wasn't right so I fixed it 👍 |
added 2 commits
July 10, 2024 15:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
📹 Screenshots/Screen capture
🔥 Notes to the tester
BasicTablehave been added in Incident Action Plan page (go to http://localhost:8081/#/test/incident-action-plan/test)