Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print all errors when validating NB configuration #14800

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

idryzhov
Copy link
Contributor

Currently, the YANG data tree validation stops on the first error that is found. As an operator has to fix all the validation errors before the config can be commited, it's useful to let them know about all the errors at once.

When printing multiple YANG errors, we should print paths for all of
them, not only for the last one.

Signed-off-by: Igor Ryzhov <[email protected]>
lib/northbound.c Outdated Show resolved Hide resolved
Copy link
Member

@ton31337 ton31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donaldsharp donaldsharp merged commit 520bb40 into FRRouting:master Nov 15, 2023
79 checks passed
@eqvinox
Copy link
Contributor

eqvinox commented Nov 20, 2023

This PR changes the minimum required version of libyang, LYD_VALIDATE_MULTI_ERROR is not available ≤ 2.1.35

@ton31337
Copy link
Member

(However, the recommended AND properly working version is 2.1.80)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants