bgpd: Coverity fixes for RPKI per-VRF #15200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CID 1575926 Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575925 Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575924 Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575923 Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575922 Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575922 Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575920 Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575919 Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575917 Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575915 Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575914 Signed-off-by: Donatas Abraitis <[email protected]>
CID 1575913 Signed-off-by: Donatas Abraitis <[email protected]>
If vrf_socket fails, need to free resources allocated by vrf_getaddrinfo(). CID 1575912 Signed-off-by: Donatas Abraitis <[email protected]>
louis-6wind
suggested changes
Jan 23, 2024
| setsockopt(socket, SOL_SOCKET, SO_SNDTIMEO, &timeout, sizeof(timeout)); | ||
| ret = getsockopt(socket, SOL_SOCKET, SO_RCVTIMEO, &prev_rcv_tmout, | ||
| &optlen); | ||
| if (ret < 0) |
There was a problem hiding this comment.
we need to free res when if (ret < 0)
There was a problem hiding this comment.
my bad, that was correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.