bgpd: fix RPKI coverity scanner issues #15201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate #15200 |
Fix potential NULL pointer in RPKI code. Coverity scanner issues: 1575911 1575913, 1575915, 1575917, 1575919 to 1575923, 1575925 and 1575926. Fixes: 1420189 ("bgpd: add support of rpki in vrf configure context") Signed-off-by: Louis Scalbert <[email protected]>
Fix deference before check coverity scanner issue 1575918 in rpki_create_socket() Fixes: a951752 ("bgpd: create cache server socket in vrf") Signed-off-by: Louis Scalbert <[email protected]>
louis-6wind
force-pushed
the
fix-rpki-coverity
branch
from
14aa827 to
fc79db8
Compare
Fix coverity scanner issue 1575912 where res pointer is supposed to valid in: > socket = vrf_socket(res->ai_family, ...) but is checked for validity a few lines later. Note that vrf_getaddrinfo returns an error code if getaddrinfo() fails to allocate res and in this case, rpki_create_socket() returns. Fixes: a951752 ("bgpd: create cache server socket in vrf") Signed-off-by: Louis Scalbert <[email protected]>
Fix memory leak in rpki_create_socket. Coverity scanner issue 1575914. Fixes: a951752 ("bgpd: create cache server socket in vrf") Signed-off-by: Louis Scalbert <[email protected]>
Check (g|s)etsockopt returns in rpki_create_socket(). Coverity scanner issues 1575916 and 1575924. Fixes: a951752 ("bgpd: create cache server socket in vrf") Signed-off-by: Louis Scalbert <[email protected]>
louis-6wind
force-pushed
the
fix-rpki-coverity
branch
from
fc79db8 to
efdb5f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 16 RPKI coverity scanner issues 1575911 to 1575926