-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd:aggr summary-only remove suppressed from evpn #15222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a topotest for this case.
@chiragshah6 any chance to add a topotest? |
@ton31337 it will take me sometime to add topotest. I will be planning to add topotest topology for EVPN use case then will incorporate this particular case as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks fine, just waiting on topo test
338cebb
to
a65dac1
Compare
@chiragshah6 can we fix frrbot styling? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python formatting, other than that - LGTM.
Ticket: #3534718 #3720960 Testing Done: Config: router bgp 65564 vrf sym_2 bgp router-id 27.0.0.9 ! address-family ipv4 unicast redistribute static exit-address-family vrf sym_2 vni 8889 ip route 63.2.1.0/24 blackhole ip route 63.2.1.2/32 blackhole ip route 63.2.1.3/32 blackhole exit-vrf tor-1:# vtysh -c "show bgp l2vpn evpn route" | grep -A3 63.2 *> [5]:[0]:[24]:[63.2.1.0] RD 27.0.0.9:19 27.0.0.9 (tor-1) 0 32768 ? ET:8 RT:28:8889 Rmac:44:38:39:ff:ff:29 -- *> [5]:[0]:[32]:[63.2.1.2] RD 27.0.0.9:19 27.0.0.9 (tor-1) 0 32768 ? ET:8 RT:28:8889 Rmac:44:38:39:ff:ff:29 *> [5]:[0]:[32]:[63.2.1.3] RD 27.0.0.9:19 27.0.0.9 (tor-1) 0 32768 ? ET:8 RT:28:8889 Rmac:44:38:39:ff:ff:29 tor-1(config)# router bgp 65564 vrf sym_2 tor-1(config-router)# address-family ipv4 unicast tor-1(config-router-af)# aggregate-address 63.2.0.0/16 summary-only tor-1(config-rou-f)# end tor-1:# vtysh -c "show bgp l2vpn evpn route" | grep -A3 63.2.1 tor-1:# vtysh -c "show bgp l2vpn evpn route" | grep -A3 63.2 *> [5]:[0]:[16]:[63.2.0.0] RD 27.0.0.9:19 27.0.0.9 (tor-1) 0 32768 ? ET:8 RT:28:8889 Rmac:44:38:39:ff:ff:29 Signed-off-by: Chirag Shah <[email protected]>
Toptotest covers to aggregate EVPN prefix routes. Testing: tests/topotests/bgp_evpn_vxlan_svd_topo1$ sudo -E python3 -m pytest -s -vv --cli-on-error PASSED test_bgp_evpn_vxlan_svd.py::test_pe_advertise_aggr_evpn_route --------------------- live log call ------------------------------- 2024-03-04 19:59:45,340 INFO: P1: checking if daemons are running 2024-03-04 19:59:45,444 INFO: PE1: checking if daemons are running 2024-03-04 19:59:45,578 INFO: PE2: checking if daemons are running 2024-03-04 19:59:45,680 INFO: host1: checking if daemons are running 2024-03-04 19:59:45,798 INFO: host2: checking if daemons are running 2024-03-04 19:59:45,896 INFO: topo: Checking BGP EVPN route contains non-aggregate prefixes 2024-03-04 19:59:45,992 INFO: topo: Configure BGP aggregate-address summary-only under ipv4-unicast 2024-03-04 19:59:46,120 INFO: topo: Checking BGP EVPN route contains aggregated prefix PASSED ------- generated xml file: /tmp/topotests/topotests.xml ----- ======= 10 passed, 1 skipped in 47.95s ===== Signed-off-by: Chirag Shah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
@Mergifyio backport dev/10.0 |
✅ Backports have been created
|
bgpd:aggr summary-only remove suppressed from evpn (backport #15222)
When aggregate summary-only cofigure, remove suppressed routes from EVPN and only advertised aggregate route.
Testing Done:
Config:
Apply aggregate:
Suppressed routes are removed:
Signed-off-by: Chirag Shah [email protected]