Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ospfd: add support for "no router-info [<area|as>] command" #15336

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

c-po
Copy link
Contributor

@c-po c-po commented Feb 8, 2024

frr-reload.py will walk through all config contexts and prepend no to the CLI command. This requires that the vtysh shell code accepts a full command.

To Reproduce

vtysh -c "conf t" -c "router ospf" -c "router-info area"
vtysh -c "conf t" -c "router ospf" -c "no router-info area" % Unknown command: no router-info area
vtysh -c "conf t" -c "router ospf" -c "no router-info"

Closes #15335

Backport to stable/9.0 and stable/9.1

frr-reload.py will walk through all config contexts and prepend no to the CLI
command. This requires that the vtysh shell code accepts a full command.

To Reproduce

vtysh -c "conf t" -c "router ospf" -c "router-info area"
vtysh -c "conf t" -c "router ospf" -c "no router-info area"
% Unknown command: no router-info area
vtysh -c "conf t" -c "router ospf" -c "no router-info"

Signed-off-by: Christian Breunig <[email protected]>
@ton31337 ton31337 added this to the 10.0 milestone Feb 9, 2024
@ton31337 ton31337 merged commit 7174a7d into FRRouting:master Feb 9, 2024
9 checks passed
@c-po c-po deleted the issue-15335 branch February 9, 2024 11:18
@c-po
Copy link
Contributor Author

c-po commented Feb 9, 2024

@ton31337 could you add the backports for stable/9.0 and stable/9.1 please?

@ton31337
Copy link
Member

ton31337 commented Feb 9, 2024

@Mergifyio backport stable/9.1 stable/9.0

Copy link

mergify bot commented Feb 9, 2024

backport stable/9.1 stable/9.0

✅ Backports have been created

donaldsharp added a commit that referenced this pull request Feb 9, 2024
ospfd: add support for "no router-info [<area|as>] command" (backport #15336)
ton31337 added a commit that referenced this pull request Feb 10, 2024
ospfd: add support for "no router-info [<area|as>] command" (backport #15336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frr-reload: ospf: unable to remove "router-info area"
2 participants