Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.4] nhrp: backport fixes #16141 and #16166 #16174

Merged
merged 2 commits into from
Jun 6, 2024

nhrpd: Fix nhrp_peer leak

d63b2d6
Select commit
Loading
Failed to load commit list.
Merged

[8.4] nhrp: backport fixes #16141 and #16166 #16174

nhrpd: Fix nhrp_peer leak
d63b2d6
Select commit
Loading
Failed to load commit list.
NetDEF CI Pull Requests Testing / [CI] Basic Tests failed Jun 6, 2024 in 0s

Basic Tests summary

➡️ Jobs in progress: 0/59

✖️ Jobs Failure: 3/59

E   AssertionError: 3 tests failed
E   AssertionError: 10 tests failed
E   AssertionError: Failed
   assert Generated JSON diff error report:
     
     > $->192.168.2.0/24: d2 has the following element at index 0 which is not present in d1: 
     
     	{
     	    "prefix": "192.168.2.0/24",
     	    "protocol": "bgp",
     	    "vrfName": "vrf10",
     	    "selected": true,
     	    "destSelected": true,
     	    "distance": 20,
     	    "metric": 0,
     	    "installed": true,
     	    "table": 10,
     	    "internalStatus": 16,
     	    "internalFlags": 8,
     	    "internalNextHopNum": 1,
     	    "internalNextHopActiveNum": 1,
     	    "nexthops": [
     	        {
     	            "flags": 3,
     	            "fib": true,
     	            "afi": "ipv6",
     	            "interfaceName": "eth0",
     	            "vrf": "default",
     	            "active": true,
     	            "weight": 1,
     	            "seg6": {
     	                "segs": "2001:db8:2:2:100::"
     	            }
     	        }
     	    ],
     	    "asPath": "2"
     	}
     
     	Closest match in d1 is at index 0 with the following errors: 
     
     	> $->192.168.2.0/24[0]: d2 has key 'asPath' which is not present in d1

✔️ Jobs Success: 56/59

Details at https://ci1.netdef.org/browse/FRR-PULLREQ3-3586.