Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: drop NEWLINK event handling in the main thread #17180

Merged
merged 1 commit into from
Oct 22, 2024
Merged

zebra: drop NEWLINK event handling in the main thread #17180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions zebra/kernel_netlink.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,10 +405,6 @@ static int netlink_information_fetch(struct nlmsghdr *h, ns_id_t ns_id,
return netlink_route_change(h, ns_id, startup);
case RTM_DELROUTE:
return netlink_route_change(h, ns_id, startup);
case RTM_NEWLINK:
return netlink_link_change(h, ns_id, startup);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've got a block a little further down where the dplane messages are kept together - it'd be more consistent to put these LINK messages there too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why/how is this useless?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've got a block a little further down where the dplane messages are kept together - it'd be more consistent to put these LINK messages there too?

Done. Thanks for your review.

case RTM_DELLINK:
return 0;
case RTM_NEWNEIGH:
case RTM_DELNEIGH:
case RTM_GETNEIGH:
Expand Down Expand Up @@ -438,6 +434,8 @@ static int netlink_information_fetch(struct nlmsghdr *h, ns_id_t ns_id,
return 0;

/* Messages handled in the dplane thread */
case RTM_NEWLINK:
case RTM_DELLINK:
case RTM_NEWADDR:
case RTM_DELADDR:
case RTM_NEWNETCONF:
Expand Down
Loading