zebra: drop NEWLINK event handling in the main thread #17180
Conversation
| @@ -406,7 +406,6 @@ static int netlink_information_fetch(struct nlmsghdr *h, ns_id_t ns_id, | |||
| case RTM_DELROUTE: | |||
| return netlink_route_change(h, ns_id, startup); | |||
| case RTM_NEWLINK: | |||
| return netlink_link_change(h, ns_id, startup); | |||
There was a problem hiding this comment.
we've got a block a little further down where the dplane messages are kept together - it'd be more consistent to put these LINK messages there too?
There was a problem hiding this comment.
we've got a block a little further down where the dplane messages are kept together - it'd be more consistent to put these LINK messages there too?
Done. Thanks for your review.
|
Can you please change the title and add a description of why you are doing it to make it easy not only for reviewers but anyone looking through the change history. Example: zebra: drop NEWLINK event handling in the main thread NEWLINK is only registered by the dplane thread, the main thread doesn't care about it. etc.... |
NEWLINK is only registered by the dplane thread, the main thread doesn't care about it. So remove the real process of `netlink_link_change()` for NEWLINK event in main thread. And move NEWLINK/DELLINK event to the block where the dplane messages are kept together. Signed-off-by: anlan_cs <[email protected]>
anlancs
force-pushed
the
zebra/review-move-dplane
branch
from
15c03d7 to
96192f6
Compare
|
Done. Thanks for your help! @Jafaral |
anlancs
changed the title
After moved to dataplane, the NEWLINK/DELLINK procedure should be also removed.