bgpd: fix version attribute is an int, not a string #17506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you fix frrbot stuff? |
|
@Mergifyio backport stable/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0 |
✅ Backports have been created
|
The json display of the version attribute is originally an
integer. It has changed, most probably mistakenly.
> {
> "vrfId": 7,
> "vrfName": "vrf1",
> "tableVersion": 3,
> "routerId": "192.0.2.1",
> "defaultLocPrf": 100,
> "localAS": 65500,
> "routes": {
> "172.31.0.1/32": {
> "prefix": "172.31.0.1/32",
> "version": "1", <--- int or string ??
Let us fix it, by using the integer display instead.
Fixes: f9f2d18 ("bgpd: fix 'json detail' output structure")
Signed-off-by: Philippe Guibert <[email protected]>
pguibert6WIND
force-pushed
the
int_versus_string
branch
from
45f338f to
c5d7815
Compare
This was referenced Nov 26, 2024
riw777
added a commit
that referenced
this pull request
Nov 26, 2024
bgpd: fix version attribute is an int, not a string (backport #17506)
riw777
added a commit
that referenced
this pull request
Nov 26, 2024
bgpd: fix version attribute is an int, not a string (backport #17506)
riw777
added a commit
that referenced
this pull request
Nov 26, 2024
bgpd: fix version attribute is an int, not a string (backport #17506)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json display of the version attribute is originally an integer. It has changed, most probably mistakenly.
Let us fix it, by using the integer display instead.
Fixes: f9f2d18 ("bgpd: fix 'json detail' output structure")