Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: fix version attribute is an int, not a string (backport #17506) #17511

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 26, 2024

The json display of the version attribute is originally an integer. It has changed, most probably mistakenly.

{
"vrfId": 7,
"vrfName": "vrf1",
"tableVersion": 3,
"routerId": "192.0.2.1",
"defaultLocPrf": 100,
"localAS": 65500,
"routes": {
"172.31.0.1/32": {
"prefix": "172.31.0.1/32",
"version": "1", <--- int or string ??

Let us fix it, by using the integer display instead.

Fixes: f9f2d18 ("bgpd: fix 'json detail' output structure")


This is an automatic backport of pull request #17506 done by Mergify.

The json display of the version attribute is originally an
integer. It has changed, most probably mistakenly.

> {
>   "vrfId": 7,
>   "vrfName": "vrf1",
>   "tableVersion": 3,
>   "routerId": "192.0.2.1",
>   "defaultLocPrf": 100,
>   "localAS": 65500,
>   "routes": {
>     "172.31.0.1/32": {
>       "prefix": "172.31.0.1/32",
>       "version": "1",		<--- int or string ??

Let us fix it, by using the integer display instead.

Fixes: f9f2d18 ("bgpd: fix 'json detail' output structure")

Signed-off-by: Philippe Guibert <[email protected]>
(cherry picked from commit c5d7815)
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit e304817 into stable/10.2 Nov 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants