Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master #60

Merged
merged 23 commits into from
Dec 4, 2023
Merged

Update master #60

merged 23 commits into from
Dec 4, 2023

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Aug 9, 2023

#47 : Add TF Sensor and URDF importer
#51 : Add NavsatFix msg publisher for GNSS
#53 : Fix README
#57 : Fix IMU calculation
#59 : Add Getter for LiDAR config

@RyodoTanaka RyodoTanaka self-requested a review October 26, 2023 15:53
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Update does not contain noise model.
I will merge this in this case.
But we need to add them ASAP, at least gaussian noise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Livox and Velodyne, GaussianNoise is already implemented.
Currently, the GaussianNoise class is not implemented because the noise generation process is implemented within parallel and GPU processing.

LivoxとVelodyneについてはガウシアンノイズは実装済みです。
これらのノイズ生成処理は並列処理などの内部に実装されているため、GaussianNoiseクラス自体はまだありません。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not word this point well enough. Sorry about that. I thought the noise was necessary for GPS and IMU. We also confirmed that Livox and Velodyne are implemented without any problems.

Regarding the noise of GPS and IMU, I would like to merge them for the following reasons and set them as future issues. 1.

  1. GPS Noise We think it is necessary to change not only GussianNoise but also its variance and outlier setting depending on the FIX situation. Therefore, we would like to set this as an issue for future implementation. We would like to implement it after setting up the noise model. 2. We need to discuss whether or not drift noise should be implemented for IMU noise as well. We believe that it is necessary to deliberate whether drift noise should be implemented for IMU noise as well.

Since the commit contents of this PR are larger than the above concerns, we would like to prioritize to merge them first. I will raise an Issue regarding the concerns.

ノイズモデルについて言葉足らずでした。申し訳ありません。上記のReview時点では、GPSとIMUにノイズが必要だとと考えていました。また、LivoxとVelodyneについても問題なく実装されていることを確認しました。

GPSとIMUのノイズの実装については、以下の理由から本PRでは一旦無視し、今後の課題としたいと思います。1.

  1. GPSノイズ
    GussianNoiseだけでなく、分散や外れ値の設定もGPSのFIXの状況に応じて変更する必要があると考えています。そのため、今後の課題として設定し、どこまでノイズモデルを設定するか決定してから実装したいと考えます。
  2. IMUノイズ
    ドリフトノイズを実装すべきかどうか議論する必要があると考えます。こちらについてもどこまでノイズモデルを設定するか決定してから実装したいと考えます。

本PRのコミット内容は上記の懸念事項よりも大きいため、優先順位をつけて先にマージしたいと思います。懸念事項についてはIssueを立てておきます。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked to #73 #74 for GPS and IMU noise models.

Copy link
Member

@RyodoTanaka RyodoTanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TF Sensor sample scene is needed to merge.

Also, in the near future, we need to add noise model for following sensors.

  • GPS
  • IMU

But those noise model is not necessary for this merge.
What we need is only add TF sensor's sample scene.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TF Sensor Sample is not added.
After adding them, I will merge it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TF is ROS onlyhttps://github.com/Field-Robotics-Japan/UnitySensors/pull/72

Since TF is one of the features that ROS has, I think the sample scene should only be implemented in UnitySensorsROS.

TFはROSの機能なので、UnitySensors側ではなくUnitySensorsROS側にのみサンプルシーンを置くべきだと考えています。
TFSensor.csがUnitySensors内に配置されているのは、ディレクトリ構成を統一するためです。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFの機能を分離したPRをマージしました。
方針についても理解しました。本件はこれで問題ないのでマージします!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample scene and sample URDF is needed, I think.
But this is not the main sensors. Thus, if there are not, I will merge it.

Copy link
Member

@RyodoTanaka RyodoTanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked latest master modification.

@RyodoTanaka RyodoTanaka self-requested a review December 4, 2023 18:58
Copy link
Member

@RyodoTanaka RyodoTanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR.
The discussion is already written in each commits.

@RyodoTanaka RyodoTanaka merged commit c37f5eb into master Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants