[MIRROR] Fixes the deployable component rotating things it isnt supposed to #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed to (#428) * Fixes the deployable component rotating things it isnt supposed to (#80877) ## About The Pull Request Actually moves the rotation part of the code under the check for if the component is supposed to rotate things ## Why It's Good For The Game Despite setting the variable for rotating stuff to no, the component would still rotate stuff, this is bad ## Changelog :cl: fix: The deployable component will now actually stop rotating things when the variable to not do that is set /:cl: * Fixes the deployable component rotating things it isnt supposed to --------- Co-authored-by: Paxilmaniac <[email protected]> Co-authored-by: NovaBot <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Jan 14, 2024
Iajret
pushed a commit
that referenced
this pull request
Mar 20, 2024
) * Converts ore_mined talley into only recording typepaths. (#82098) ## About The Pull Request This Pull request makes it so that the blackbox `ore_mined` talley will now only record the mineral stack's typepath as opposed to a 50/50 mix of names and typepaths. ## Why It's Good For The Game Fixes #82042. Logging should be as descriptive as possible while also avoiding the possibility for misunderstanding, so using the typepath for logging on the blackbox is preferred. ## Changelog :cl: code: Mineral logging now collects ore names more cleanly. /:cl: * Converts ore_mined talley into only recording typepaths. --------- Co-authored-by: ArcaneMusic <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Mar 20, 2024
) (#2487) * Converts ore_mined talley into only recording typepaths. (#82098) ## About The Pull Request This Pull request makes it so that the blackbox `ore_mined` talley will now only record the mineral stack's typepath as opposed to a 50/50 mix of names and typepaths. ## Why It's Good For The Game Fixes #82042. Logging should be as descriptive as possible while also avoiding the possibility for misunderstanding, so using the typepath for logging on the blackbox is preferred. ## Changelog :cl: code: Mineral logging now collects ore names more cleanly. /:cl: * Converts ore_mined talley into only recording typepaths. --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: ArcaneMusic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#428
Original PR: tgstation/tgstation#80877
About The Pull Request
Actually moves the rotation part of the code under the check for if the component is supposed to rotate things
Why It's Good For The Game
Despite setting the variable for rotating stuff to no, the component would still rotate stuff, this is bad
Changelog
🆑 Paxilmaniac
fix: The deployable component will now actually stop rotating things when the variable to not do that is set
/:cl: