Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Joker wont automatically reactivate itself #2065

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1053
Original PR: tgstation/tgstation#81547

About The Pull Request

The DNA console's Joker button, when used and goes through its cooldown, currently automatically reactivates itself, which causes Geneticists who aren't aware of this and who do not want to use their joker yet, waste it and have to wait its cooldown once again.

Why It's Good For The Game

You are waiting at minimum a 300 second timer (on t4) between Joker uses, so I do not expect people to think that this is something that would remain active once its cooldown has expired. It's just better UI.

Changelog

🆑 JohnFulpWillard
fix: The DNA scanner's joker button no longer instantly activates itself when the cooldown between uses is done.
/:cl:

* Joker wont automatically reactivate itself (#81547)

## About The Pull Request

The DNA console's Joker button, when used and goes through its cooldown,
currently automatically reactivates itself, which causes Geneticists who
aren't aware of this and who do not want to use their joker yet, waste
it and have to wait its cooldown once again.

## Why It's Good For The Game

You are waiting at minimum a 300 second timer (on t4) between Joker
uses, so I do not expect people to think that this is something that
would remain active once its cooldown has expired. It's just better UI.

## Changelog

:cl:
fix: The DNA scanner's joker button no longer instantly activates itself
when the cooldown between uses is done.
/:cl:

* Joker wont automatically reactivate itself

---------

Co-authored-by: John Willard <[email protected]>
@Iajret Iajret merged commit 9ef62a8 into master Feb 20, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1053 branch February 20, 2024 11:42
AnywayFarus added a commit that referenced this pull request Feb 20, 2024
Iajret added a commit that referenced this pull request Apr 19, 2024
…ble for ancient protolathes (#2065)

* Fixes cooling and anti-disruption RCD upgrades being unavialble for ancient protolathes (#82719)

## About The Pull Request
Makes this upgrades available for ghostroles and such


![image](https://github.com/tgstation/tgstation/assets/8430839/01b4a947-1108-4c2f-86d6-df134e20c14c)
## Why It's Good For The Game
Having ability to use RCD faster iskinda good
## Changelog
:cl:
fix: cooling and anti-disruption RCD upgrades can now be printed in
ancient protolathes
/:cl:

* Fixes cooling and anti-disruption RCD upgrades being unavialble for ancient protolathes

---------

Co-authored-by: Iajret <[email protected]>
ReezeBL pushed a commit that referenced this pull request Apr 19, 2024
…ble for ancient protolathes (#2065) (#2951)

* Fixes cooling and anti-disruption RCD upgrades being unavialble for ancient protolathes (#82719)

## About The Pull Request
Makes this upgrades available for ghostroles and such


![image](https://github.com/tgstation/tgstation/assets/8430839/01b4a947-1108-4c2f-86d6-df134e20c14c)
## Why It's Good For The Game
Having ability to use RCD faster iskinda good
## Changelog
:cl:
fix: cooling and anti-disruption RCD upgrades can now be printed in
ancient protolathes
/:cl:

* Fixes cooling and anti-disruption RCD upgrades being unavialble for ancient protolathes

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Iajret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants