[MIRROR] Adds a subtle ghost poll #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a subtle ghost poll (#79105) ## About The Pull Request This makes a new ghost poll system which doesn't give TGUI popups - instead, users are prompted to follow the POI and one of the orbiters is chosen. The old system remains in place, so you can still prompt if you want to. This gives two things: 1. A deadchat notification:  2. A screen alert:  ## Why It's Good For The Game As stated in #76507, popups are pretty annoying. This is halfway between a screen alert with no time limit and an event with more important pings. This is better because: 1. Less popup fatigue 2. You can SEE how many you're competing with 4. DRY ## Changelog :cl: add: Adds a subtle ghost poll. This pings in dead chat and gives a screen alert, but no TGUI popup. Orbit the point of interest to be selected for the role. refactor: A number of ghost spawns now feature this alert. Write an issue report if anything breaks. /:cl: --------- Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com> * Adds a subtle ghost poll --------- Co-authored-by: Jeremiah <[email protected]> Co-authored-by: MrMelbert <51863163+MrMelbert@ users.noreply.github.com>
AnywayFarus
added a commit
that referenced
this pull request
Oct 23, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 3, 2024
* borgs dont dgasp twice when dying (#80671) ## About The Pull Request fixes #80552 removes a single if statement that makes borgs dgasp when dying to _not_ gibbing, which they already did from what i checked mob/living/silicon/death(gibbed) didnt do much, but idk if its something important ## Why It's Good For The Game Cyborgs couldnt play dead since a single dgasp meant the cyborg wasnt dead ## Changelog :cl: fix: Cyborgs do not deathgasp twice when dying anymore /:cl: * borgs dont dgasp twice when dying --------- Co-authored-by: uaioy <[email protected]> Co-authored-by: NovaBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24503
Original PR: tgstation/tgstation#79105
About The Pull Request
This makes a new ghost poll system which doesn't give TGUI popups - instead, users are prompted to follow the POI and one of the orbiters is chosen. The old system remains in place, so you can still prompt if you want to.
This gives two things:
Why It's Good For The Game
As stated in #76507, popups are pretty annoying. This is halfway between a screen alert with no time limit and an event with more important pings. This is better because:
Changelog
🆑 jlsnow301
add: Adds a subtle ghost poll. This pings in dead chat and gives a screen alert, but no TGUI popup. Orbit the point of interest to be selected for the role.
refactor: A number of ghost spawns now feature this alert. Write an issue report if anything breaks.
/:cl: