[MIRROR] Add smooth transition between hidden and visible pipes #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add smooth transition between hidden and visible pipes (#81800) ## About The Pull Request - Adds smooth transition between hidden and visible pipes, AKA “caps” and updates automated pipe icon generator to account mentioned changes. - Adds centering to missed atmos machinery, for example, unary vent is almost identical to passive, but the second one wasn't centered while hidden. - Fixes visual bug with extra and unremovable by normal means pixel offset on pipes constructed from `/obj/item/pipe`. - Fixes visual bug with visible cap on a hidden connector. I'm really sorry for this mess, but one-line fixes are okay, or are they? ## Why It's Good For The Game We're playing atmospherics simulator and pipes play an essential role in our rounds, people see them all the time and that's why pipes deserve to look a bit better. This project aims to resolve said issue by adding transition states, in current implementation they're just cut off when connected to a hidden segment. <details> <summary>Screenshots</summary> Before:  After:  Extra:  </details> ## Changelog :cl: fix: Pipe connector no longer appears on a hidden connector. fix: Re-wrenched atmospherics pipes no longer get extra offset. fix: All unary devices like injectors, passive vents etc. are centered while hidden. image: Added smooth transition between hidden and visible pipes. /:cl: --------- Co-authored-by: san7890 <[email protected]> * Add smooth transition between hidden and visible pipes --------- Co-authored-by: Interception&? <[email protected]> Co-authored-by: san7890 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 8, 2024
Iajret
pushed a commit
that referenced
this pull request
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1293
Original PR: tgstation/tgstation#81800
About The Pull Request
/obj/item/pipe.I'm really sorry for this mess, but one-line fixes are okay, or are they?
Why It's Good For The Game
We're playing atmospherics simulator and pipes play an essential role in our rounds, people see them all the time and that's why pipes deserve to look a bit better. This project aims to resolve said issue by adding transition states, in current implementation they're just cut off when connected to a hidden segment.
Screenshots
Before:
After:
Extra:
Changelog
🆑 intercepti0n
fix: Pipe connector no longer appears on a hidden connector.
fix: Re-wrenched atmospherics pipes no longer get extra offset.
fix: All unary devices like injectors, passive vents etc. are centered while hidden.
image: Added smooth transition between hidden and visible pipes.
/:cl: