Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Summon Simians Max Level Reward Change #2400

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1434
Original PR: tgstation/tgstation#81875

About The Pull Request

Summon Simian now, as opposed to summoning actual gorillas at max level, the caster is instead granted a free gorilla transformation spell instead.

Why It's Good For The Game

I wasn't exactly aware that Summon Simians could summon actual gorillas when I buffed gorillas mainly for traitors, so wizards could use the max level spell to spam powerful gorillas who could easily wipe the station in a very short amount of time. Ideally, this change should reign in max level Summon Simians while still giving users a reason to max it out.

Changelog

🆑 IndieanaJones
balance: Max level Summon Simians now grants the wizard a free gorilla transformation spell as opposed to allowing the wizard to summon fully-grown gorillas.
/:cl:

* Summon Simians Max Level Reward Change (#81875)

## About The Pull Request

Summon Simian now, as opposed to summoning actual gorillas at max level,
the caster is instead granted a free gorilla transformation spell
instead.

## Why It's Good For The Game

I wasn't exactly aware that Summon Simians could summon actual gorillas
when I buffed gorillas mainly for traitors, so wizards could use the max
level spell to spam powerful gorillas who could easily wipe the station
in a very short amount of time. Ideally, this change should reign in max
level Summon Simians while still giving users a reason to max it out.

## Changelog
:cl:
balance: Max level Summon Simians now grants the wizard a free gorilla
transformation spell as opposed to allowing the wizard to summon
fully-grown gorillas.
/:cl:

* Summon Simians Max Level Reward Change

---------

Co-authored-by: IndieanaJones <[email protected]>
@Iajret Iajret merged commit da3442b into master Mar 14, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1434 branch March 14, 2024 11:18
AnywayFarus added a commit that referenced this pull request Mar 14, 2024
Iajret pushed a commit that referenced this pull request May 9, 2024
…th smoothed textures including a non-smoothed broken overlay displaying some black void (#2400)

* Gives broken/burnt grass a smoothed texture, fixes issues with smoothed textures including a non-smoothed broken overlay displaying some black void (#83128)

## About The Pull Request
What it says on the tin. The second part of the title is technically not
currently used, but it's going to help a lot with any downstreams that
might be experiencing those issues, or for anyone in the future that
might not want to go through the troubles of adding a broken state for
their smoothed turf.

## Why It's Good For The Game
It looks nicer.

![image](https://github.com/tgstation/tgstation/assets/58045821/3dad6fb3-2fa8-402c-901e-ed816f857c63)

Credits to @Thlumyn for the pretty sprites!

I did consider using the original broken jungle grass sprites (which
were currently not used because of a typepath typo), but I elected not
to, because I think that it looks better when smoothed out, than when it
isn't smoothed out.
Here's what it looked like before my last commit:

![image](https://github.com/tgstation/tgstation/assets/58045821/8b65f8c7-99c0-4e4a-99da-62d2ec69a1e3)


## Changelog

:cl: GoldenAlpharex for the code, Thlumyn for the sprites
fix: Fixed smoothing turfs displaying some incorrect damaged overlays
because of a non-smoothing damage overlay of different dimensions than
the smoothing sprite used as the base. Less black void, let's go!
image: Added smooth broken/burnt overlays for grass, meaning that it's
going to look a lot less broken when the grass tile is at the edge of a
smoothing group.
/:cl:

* Gives broken/burnt grass a smoothed texture, fixes issues with smoothed textures including a non-smoothed broken overlay displaying some black void

---------

Co-authored-by: GoldenAlpharex <[email protected]>
ReezeBL pushed a commit that referenced this pull request May 9, 2024
…th smoothed textures including a non-smoothed broken overlay displaying some black void (#2400) (#3250)

* Gives broken/burnt grass a smoothed texture, fixes issues with smoothed textures including a non-smoothed broken overlay displaying some black void (#83128)

## About The Pull Request
What it says on the tin. The second part of the title is technically not
currently used, but it's going to help a lot with any downstreams that
might be experiencing those issues, or for anyone in the future that
might not want to go through the troubles of adding a broken state for
their smoothed turf.

## Why It's Good For The Game
It looks nicer.

![image](https://github.com/tgstation/tgstation/assets/58045821/3dad6fb3-2fa8-402c-901e-ed816f857c63)

Credits to @Thlumyn for the pretty sprites!

I did consider using the original broken jungle grass sprites (which
were currently not used because of a typepath typo), but I elected not
to, because I think that it looks better when smoothed out, than when it
isn't smoothed out.
Here's what it looked like before my last commit:

![image](https://github.com/tgstation/tgstation/assets/58045821/8b65f8c7-99c0-4e4a-99da-62d2ec69a1e3)


## Changelog

:cl: GoldenAlpharex for the code, Thlumyn for the sprites
fix: Fixed smoothing turfs displaying some incorrect damaged overlays
because of a non-smoothing damage overlay of different dimensions than
the smoothing sprite used as the base. Less black void, let's go!
image: Added smooth broken/burnt overlays for grass, meaning that it's
going to look a lot less broken when the grass tile is at the edge of a
smoothing group.
/:cl:

* Gives broken/burnt grass a smoothed texture, fixes issues with smoothed textures including a non-smoothed broken overlay displaying some black void

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: GoldenAlpharex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants