[MIRROR] Fixes the larva "hide" ability not properly hiding larvas under tables. #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…larvas under tables. (#1436) * [NO GBP] Fixes the larva "hide" ability not properly hiding larvas under tables. (#81921) ## About The Pull Request This PR fixes yet another small issue with elevation. ## Why It's Good For The Game This PR fixes yet another small issue with elevation. ## Changelog :cl: fix: Fixed the larva "hide" ability not properly hiding larvas under tables. /:cl: * [NO GBP] Fixes the larva "hide" ability not properly hiding larvas under tables. --------- Co-authored-by: Ghom <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 14, 2024
Iajret
pushed a commit
that referenced
this pull request
May 9, 2024
… ghost role based events (#2404) * Fixes some missing poll_ghost_candidates sanity checking for ghost role based events (#83107) poll_ghost_candidates can return null if nobody signs up, these weren't properly checking for that case. Also moved the Santa ghost role over to the proper subtype (not sure if it was outright broken, but it'll now properly update the Santa's role and trigger automatically.) ``` [14:41:54] Runtime in code/modules/events/ghost_role/sentience.dm, line 77: Cannot read null.vars proc name: spawn role (/datum/round_event/ghost_role/sentience/spawn_role) src: /datum/round_event/ghost_role/... (/datum/round_event/ghost_role/sentience) call stack: /datum/round_event/ghost_role/... (/datum/round_event/ghost_role/sentience): spawn role() /datum/round_event/ghost_role/... (/datum/round_event/ghost_role/sentience): try spawning() /datum/round_event/ghost_role/... (/datum/round_event/ghost_role/sentience): start() /datum/round_event/ghost_role/... (/datum/round_event/ghost_role/sentience): process(2) Events (/datum/controller/subsystem/events): fire(0) Events (/datum/controller/subsystem/events): ignite(0) Master (/datum/controller/master): RunQueue() Master (/datum/controller/master): Loop(2) Master (/datum/controller/master): StartProcessing(0) ``` --------- Co-authored-by: MrMelbert <[email protected]> * Fixes some missing poll_ghost_candidates sanity checking for ghost role based events --------- Co-authored-by: Afevis <[email protected]> Co-authored-by: MrMelbert <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
May 9, 2024
… ghost role based events (#2404) (#3251) * Fixes some missing poll_ghost_candidates sanity checking for ghost role based events (#83107) poll_ghost_candidates can return null if nobody signs up, these weren't properly checking for that case. Also moved the Santa ghost role over to the proper subtype (not sure if it was outright broken, but it'll now properly update the Santa's role and trigger automatically.) ``` [14:41:54] Runtime in code/modules/events/ghost_role/sentience.dm, line 77: Cannot read null.vars proc name: spawn role (/datum/round_event/ghost_role/sentience/spawn_role) src: /datum/round_event/ghost_role/... (/datum/round_event/ghost_role/sentience) call stack: /datum/round_event/ghost_role/... (/datum/round_event/ghost_role/sentience): spawn role() /datum/round_event/ghost_role/... (/datum/round_event/ghost_role/sentience): try spawning() /datum/round_event/ghost_role/... (/datum/round_event/ghost_role/sentience): start() /datum/round_event/ghost_role/... (/datum/round_event/ghost_role/sentience): process(2) Events (/datum/controller/subsystem/events): fire(0) Events (/datum/controller/subsystem/events): ignite(0) Master (/datum/controller/master): RunQueue() Master (/datum/controller/master): Loop(2) Master (/datum/controller/master): StartProcessing(0) ``` --------- * Fixes some missing poll_ghost_candidates sanity checking for ghost role based events --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Afevis <[email protected]> Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1436
Original PR: tgstation/tgstation#81921
About The Pull Request
This PR fixes yet another small issue with elevation.
Why It's Good For The Game
This PR fixes yet another small issue with elevation.
Changelog
🆑 Ghommie
fix: Fixed the larva "hide" ability not properly hiding larvas under tables.
/:cl: