[MIRROR] Placing things in a paperbin actually plays sounds. #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Placing things in a paperbin actually plays sounds. (#81974) ## About The Pull Request In contrast to my previous pr: Really just changes the `user.transferItemToLoc(...)` used for transferring paper to the bin to have a `silent = FALSE` parameter. Also did it for pens for good measure, though I believe most pens don't have such sounds yet. ## Why It's Good For The Game Placing paper on a table makes sounds, placing paper in a bin makes no sound. This feels awkward. This changes that to actually make a sound. Also adds `silent = FALSE` to placing pens on it for good measure, though most pens don't have such sounds yet. ## Changelog :cl: sound: Placing paper in a paperbin is no longer silent. /:cl: * Placing things in a paperbin actually plays sounds. --------- Co-authored-by: _0Steven <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 17, 2024
Iajret
pushed a commit
that referenced
this pull request
May 10, 2024
* Changes * Update modular_nova/modules/reagent_forging/code/forge.dm * Missed one * Missed two --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1455
Original PR: tgstation/tgstation#81974
About The Pull Request
In contrast to my previous pr:
Really just changes the
user.transferItemToLoc(...)used for transferring paper to the bin to have asilent = FALSEparameter.Also did it for pens for good measure, though I believe most pens don't have such sounds yet.
Why It's Good For The Game
Placing paper on a table makes sounds, placing paper in a bin makes no sound. This feels awkward.
This changes that to actually make a sound.
Also adds
silent = FALSEto placing pens on it for good measure, though most pens don't have such sounds yet.Changelog
🆑 00-Steven
sound: Placing paper in a paperbin is no longer silent.
/:cl: