[MIRROR] Fix psyker echolocation lag #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix psyker echolocation lag (#82005) ## About The Pull Request Fixes a slowly increasing lag for psykers, subtly introduced by #80042 Turns out the code expects all of the images to fully fade out before any new images start fading in, thus the expiry time + fade out time must not exceed the cooldown time. Note that this will still be laggier than if you're NOT a psyker because of how things are rendered, but it should stay consistent. Fixes #81446 Fixes #80442 Fixes #80798 ## Why It's Good For The Game letting literally thousands of images build up on the client is not a good thing, turns out. ## Changelog :cl: fix: Psyker vision no longer causes infinitely worsening lag /:cl: * Fix psyker echolocation lag --------- Co-authored-by: FlufflesTheDog <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Mar 17, 2024
Iajret
pushed a commit
that referenced
this pull request
May 13, 2024
* Food vendors actually drop their appropriate parts * null abstract object's icon state * subtypesof is a thing that exists Co-authored-by: Bloop <[email protected]> --------- Co-authored-by: Bloop <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1472
Original PR: tgstation/tgstation#82005
About The Pull Request
Fixes a slowly increasing lag for psykers, subtly introduced by #80042
Turns out the code expects all of the images to fully fade out before any new images start fading in, thus the expiry time + fade out time must not exceed the cooldown time.
Note that this will still be laggier than if you're NOT a psyker because of how things are rendered, but it should stay consistent.
Fixes #81446
Fixes #80442
Fixes #80798
Why It's Good For The Game
letting literally thousands of images build up on the client is not a good thing, turns out.
Changelog
🆑 FlufflesTheDog
fix: Psyker vision no longer causes infinitely worsening lag
/:cl: