Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Disposal bins can now hold a destination tagger, and adds a few throughout maps. #2467

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1506
Original PR: tgstation/tgstation#81991

About The Pull Request

image
Pictured, a disposal bin with a mounted destination tagger.

Disposal bins now have a dedicated mount where they can hold a destination tagger, allowing for crewmates to more easily send items through disposals to other departments. This can be especially useful when on larger maps, or when cooperating on larger maps with remote resources like on viro/xenobio.

All disposal bins can hold a destination tagger, but select ones on maps have one pre-loaded.
Disposal bins can be removed with an empty hand and right click, and re-attached with right click as well.

Why It's Good For The Game

This helps assist with crew cooperation on maps where remote or otherwise inaccessible departments have to really work to cooperate and send resources, this chips away at the barrier of entry by giving most departments a way to send resources back and forth as necessary through the disposals network. It ALSO allows for additional opportunities for players to send dangerous items like bombs or grenades through disposals using destination taggers indirectly 👍

Changelog

🆑 ArcaneMusic
add: Disposal bins can now hold destination taggers using right click, and can be removed the same way. Some disposal bins should have some pre-loaded as well.
/:cl:

…few throughout maps. (#1506)

* Disposal bins can now hold a destination tagger, and adds a few throughout maps. (#81991)

## About The Pull Request

![image](https://github.com/tgstation/tgstation/assets/41715314/5af9517f-ef5f-4284-aa87-bbf17170570e)
_Pictured, a disposal bin with a mounted destination tagger._

Disposal bins now have a dedicated mount where they can hold a
destination tagger, allowing for crewmates to more easily send items
through disposals to other departments. This can be especially useful
when on larger maps, or when cooperating on larger maps with remote
resources like on viro/xenobio.

All disposal bins can hold a destination tagger, but select ones on maps
have one pre-loaded.
Disposal bins can be removed with an empty hand and right click, and
re-attached with right click as well.

## Why It's Good For The Game

This helps assist with crew cooperation on maps where remote or
otherwise inaccessible departments have to really work to cooperate and
send resources, this chips away at the barrier of entry by giving most
departments a way to send resources back and forth as necessary through
the disposals network. It ALSO allows for additional opportunities for
players to send dangerous items like bombs or grenades through disposals
using destination taggers indirectly 👍

## Changelog

:cl:
add: Disposal bins can now hold destination taggers using right click,
and can be removed the same way. Some disposal bins should have some
pre-loaded as well.
/:cl:

---------

Co-authored-by: san7890 <[email protected]>
Co-authored-by: Jordan Dominion <[email protected]>

* Disposal bins can now hold a destination tagger, and adds a few throughout maps.

* Adds tagger icon state

pending inspection in game to see if it looks ok or needs editing

---------

Co-authored-by: ArcaneMusic <[email protected]>
Co-authored-by: san7890 <[email protected]>
Co-authored-by: Jordan Dominion <[email protected]>
Co-authored-by: SomeRandomOwl <[email protected]>
@ReezeBL ReezeBL merged commit 5ee412c into master Mar 20, 2024
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-1506 branch March 20, 2024 07:23
AnywayFarus added a commit that referenced this pull request Mar 20, 2024
Iajret pushed a commit that referenced this pull request May 15, 2024
* Portals now make sounds (#83166)

## About The Pull Request
### New sounds:

https://drive.google.com/drive/folders/1vLoyxY93Qfe_GtCnetkEHLrkGYZ8S7nD?usp=sharing

Demo:


https://github.com/tgstation/tgstation/assets/96586172/2c468ab8-deea-4151-8d66-167b63fdda39



Changes teleporter,gulag teleporter, hand tele, bluespace teleport gun,
cultist teleport, experimental syndicate teleporter teleport sounds.
## Why It's Good For The Game
I think sounds are an integral part of immersion and having no cool
sci-fi noises for portals really spoils it.
## Changelog
:cl: grungussuss and Virgilcore
sound: portals now have a unique sound to them
/:cl:

* Portals now make sounds

---------

Co-authored-by: Sadboysuss <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
ReezeBL pushed a commit that referenced this pull request May 15, 2024
* Portals now make sounds (#83166)

## About The Pull Request
### New sounds:

https://drive.google.com/drive/folders/1vLoyxY93Qfe_GtCnetkEHLrkGYZ8S7nD?usp=sharing

Demo:


https://github.com/tgstation/tgstation/assets/96586172/2c468ab8-deea-4151-8d66-167b63fdda39



Changes teleporter,gulag teleporter, hand tele, bluespace teleport gun,
cultist teleport, experimental syndicate teleporter teleport sounds.
## Why It's Good For The Game
I think sounds are an integral part of immersion and having no cool
sci-fi noises for portals really spoils it.
## Changelog
:cl: grungussuss and Virgilcore
sound: portals now have a unique sound to them
/:cl:

* Portals now make sounds

---------

Co-authored-by: NovaBot <[email protected]>
Co-authored-by: Sadboysuss <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants