Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes spurious runtime caused by icemoon (again) #2842

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1923
Original PR: tgstation/tgstation#82582

About The Pull Request

tgstation/tgstation#82572 I tried to fix this but there was an unaccounted race condition which just caused a separate runtime...

firefox_GxGibAO281

Since the type is being changed mid-execution replacement_turf will become out of scope. My bad--this should fix it now for good.

…1923)

* [NO GBP] Fixes spurious runtime caused by icemoon (again) (#82582)

tgstation/tgstation#82572 I tried to fix this
but there was an unaccounted race condition which just caused a separate
runtime...

![firefox_GxGibAO281](https://github.com/tgstation/tgstation/assets/13398309/f251aecc-ef17-4bae-a741-5aade40de423)

Since the type is being changed mid-execution `replacement_turf` will
become out of scope. My bad--this should fix it now for good.

* [NO GBP] Fixes spurious runtime caused by icemoon (again)

---------

Co-authored-by: Bloop <[email protected]>
@Steals-The-PRs Steals-The-PRs added Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror labels Apr 11, 2024
@Iajret Iajret merged commit ce60a06 into master Apr 12, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1923 branch April 12, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants