[MIRROR] Reverts parts of #82602 (nodeath checks) #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reverts parts of #82602 (nodeath checks) (#82637) ## About The Pull Request Reverts the nodeath checks of #82602 I opened a review thinking these checks were sus and the PR author said they would remove them, but it was merged before that happened. TL;DR 1. I just noticed this now but it only affects carbons / humans it doesn't even cover living or any other subtypes 2. Kinda sus. Some code intentionally skips checking nodeath (I guess? Like removing the brain for example) so we would need a larger audit of this rather than haphazardly throwing it in. * Reverts parts of #82602 (nodeath checks) --------- Co-authored-by: MrMelbert <[email protected]>
Iajret
pushed a commit
that referenced
this pull request
Jun 8, 2024
…2890) * Fixes techfab print runtime for non apc areas (#83768) ## About The Pull Request Same problem for techfabs as mentioned in #83587 ## Changelog :cl: fix: techfabs don't runtime & hang when printing in no apc areas /:cl: * Fixes techfab print runtime for non apc areas --------- Co-authored-by: SyncIt21 <[email protected]> Co-authored-by: NovaBot13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1991
Original PR: tgstation/tgstation#82637
About The Pull Request
Reverts the nodeath checks of #82602
I opened a review thinking these checks were sus and the PR author said they would remove them, but it was merged before that happened.
TL;DR