Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [no gbp] Space Ruin bioscramblers shouldn't chase people around #2914

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#2009
Original PR: tgstation/tgstation#82649

About The Pull Request

See title
They wouldn't lock on to people on the station from a space ruin, but would to whoever entered their z level the second it was entered.
Also fixes bug where I changed status_flags to status_effects for some reason which isn't where you look for godmode

Why It's Good For The Game

We have a space ruin whcih several (coreless) anomalies spawn on, the bioscrambler was put as an option because it was already immortal. It's weird though to zone into the ruin and immediately have every anomaly in there lock onto you, the best intended effect is probably for these ones specifically not to be bloodthirsty.
We kind of only care about that behaviour on the station.

Changelog

🆑 Jacquerel
fix: Anomalous Research ruin Bioscrambler anomalies won't home in on targets
fix: Bioscrambler won't randomly drop its target for no reason
/:cl:

…und (#2009)

* [no gbp] Space Ruin bioscramblers shouldn't chase people around (#82649)

## About The Pull Request

See title
They wouldn't lock on to people on the station from a space ruin, but
would to whoever entered their z level the second it was entered.
Also fixes bug where I changed `status_flags` to `status_effects` for
some reason which isn't where you look for godmode

## Why It's Good For The Game

We have a space ruin whcih several (coreless) anomalies spawn on, the
bioscrambler was put as an option because it was already immortal. It's
weird though to zone into the ruin and immediately have every anomaly in
there lock onto you, the best intended effect is probably for these ones
specifically not to be bloodthirsty.
We kind of only care about that behaviour on the station.

## Changelog

:cl:
fix: Anomalous Research ruin Bioscrambler anomalies won't home in on
targets
fix: Bioscrambler won't randomly drop its target for no reason
/:cl:

* [no gbp] Space Ruin bioscramblers shouldn't chase people around

---------

Co-authored-by: Jacquerel <[email protected]>
@Iajret Iajret merged commit 0e80ea1 into master Apr 16, 2024
27 checks passed
@Iajret Iajret deleted the upstream-mirror-2009 branch April 16, 2024 13:15
AnywayFarus added a commit that referenced this pull request Apr 16, 2024
Iajret pushed a commit that referenced this pull request Jun 8, 2024
…#2914)

* Adds a TRAIT_NO_TRANSFORM check to AI movement. (#83621)

## About The Pull Request
Checks for `TRAIT_NO_TRANSFORM` in `allowed_to_move`. Will stop mobs
from moving when they should not.

## Why It's Good For The Game
Fixes #79870
Fixes AI movement not respecting TRAIT_NO_TRANSFORM.

## Changelog
:cl: Goat
fix: mobs no longer move during cutscenes
/:cl:

* Adds a TRAIT_NO_TRANSFORM check to AI movement.

---------

Co-authored-by: Goat <[email protected]>
Co-authored-by: NovaBot13 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants