Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Sunders the many unused sprites and organizes what's left in structures.dmi #2925

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#2016
Original PR: tgstation/tgstation#82658

About The Pull Request

Hello again, I noticed the /obj/structures.dmi file had a lot of unused stuff like tables from two generations ago, so I changed some stuff around:

  • Many unused, old icons deleted, mostly window variants used in old smoothing systems I imagine
  • Reorganized many sprites in the file so they're more grouped together
  • Tweaked some barricade sprite naming to be consistent/standardized, and to let others know they're not too old...
  • Fixed a misnomer that I believe was making directional tinted windows look like frosted windows

Why It's Good For The Game

Saves on file space, and satisfies your brain's pattern recognition bits

Spriting

Old:
image

New:
image
also good lord those linen bin sprites are a crime

Changelog

🆑 AMyriad
fix: Probably fixed directional tinted windows looking like directional frosted windows
image: Deleted a bunch of unused structure sprites
/:cl:

… structures.dmi (#2016)

* Sunders the many unused sprites and organizes what's left in structures.dmi (#82658)

## About The Pull Request
Hello again, I noticed the /obj/structures.dmi file had a lot of unused
stuff like tables from two generations ago, so I changed some stuff
around:
- Many unused, old icons deleted, mostly window variants used in old
smoothing systems I imagine
- Reorganized many sprites in the file so they're more grouped together
- Tweaked some barricade sprite naming to be consistent/standardized,
and to let others know they're not _too_ old...
- Fixed a misnomer that I believe was making directional tinted windows
look like frosted windows

## Why It's Good For The Game
Saves on file space, and satisfies your brain's pattern recognition bits

### Spriting
Old: 

![image](https://github.com/tgstation/tgstation/assets/143908044/0717940e-787e-40ee-85e2-0a0c5ebc0837)

New:

![image](https://github.com/tgstation/tgstation/assets/143908044/3954ba3b-b261-4700-986a-d30f3aa0e2a6)
also good lord those linen bin sprites are a crime

## Changelog
:cl:
fix: Probably fixed directional tinted windows looking like directional
frosted windows
image: Deleted a bunch of unused structure sprites
/:cl:

* Sunders the many unused sprites and organizes what's left in structures.dmi

---------

Co-authored-by: AMyriad <[email protected]>
@Iajret Iajret merged commit c471a2d into master Apr 17, 2024
27 checks passed
@Iajret Iajret deleted the upstream-mirror-2016 branch April 17, 2024 12:11
AnywayFarus added a commit that referenced this pull request Apr 17, 2024
Iajret pushed a commit that referenced this pull request Jun 13, 2024
#2925)

* hearthkin-lung-magic-wooo

* Update modular_nova/modules/icemoon_additions/code/icecat_recipes.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/icemoon_additions/code/icecat_recipes.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/icemoon_additions/code/icecat_recipes.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/icemoon_additions/code/icecat_recipes.dm

Co-authored-by: Bloop <[email protected]>

* Update modular_nova/modules/icemoon_additions/code/icecat_recipes.dm

Co-authored-by: Bloop <[email protected]>

---------

Co-authored-by: Bloop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants