Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Sutures now heal a percentage of basic/animal max health instead of a flat amount #320

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24620
Original PR: tgstation/tgstation#79266

About The Pull Request

Changes the amount of HP gained when treating basic and animal mobs. For today mobs receive treatment equal to the half treatment of the selected object like sutures heal 5 hp.

Because of this, mobs with a large amount of HP, such as gorillas, spend one stack of sutures to heal themselves for 1-3% of HP, while mobs with a small amount of HP, for example 25 HP, will receive treatment equal to 20%.

With this PR, all basic/animal mobs receive the same % of HP equal to the amount of healing for using one healing object. Like if sutures heal 10 brute damage, it will heal 10% of basic/animal mob HP.

Why It's Good For The Game

Makes treatment for basic and animal mobs more understandable and less resource-intensive, like if you heal basic/animal mob with 100 hp or 220 hp you will need the same number of sutures.

Changelog

🆑 Xackii
balance: Sutures now heal a percentage of basic/animal max health instead of a flat amount.
/:cl:

…tead of a flat amount [MDB IGNORE] (#24620)

* Sutures now heal a percentage of basic/animal max health instead of a flat amount (#79266)

## About The Pull Request

Changes the amount of HP gained when treating basic and animal mobs. For
today mobs receive treatment equal to the half treatment of the selected
object like sutures heal 5 hp.

Because of this, mobs with a large amount of HP, such as gorillas, spend
one stack of sutures to heal themselves for 1-3% of HP, while mobs with
a small amount of HP, for example 25 HP, will receive treatment equal to
20%.

With this PR, all basic/animal mobs receive the same % of HP equal to
the amount of healing for using one healing object. Like if sutures heal
10 brute damage, it will heal 10% of basic/animal mob HP.

## Why It's Good For The Game

Makes treatment for basic and animal mobs more understandable and less
resource-intensive, like if you heal basic/animal mob with 100 hp or 220
hp you will need the same number of sutures.

## Changelog

:cl:
balance: Sutures now heal a percentage of basic/animal max health
instead of a flat amount.
/:cl:

* Sutures now heal a percentage of basic/animal max health instead of a flat amount

---------

Co-authored-by: Xackii <[email protected]>
@Iajret Iajret merged commit eb6bfdf into master Oct 28, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-24620 branch October 28, 2023 12:28
AnywayFarus added a commit that referenced this pull request Oct 28, 2023
Iajret pushed a commit that referenced this pull request Jan 5, 2024
* Fixes netpod healing exploit (#80717)

## About The Pull Request
This PR addresses an issue where netpod healing effects persisted under
certain conditions (Issue #80715). Specifically, when a netpod is
destroyed with a player inside, the embryonic stasis effect improperly
continued. This adds another cases where the user is teleported out by
other means (not currently a known issue).
## Why It's Good For The Game
Fixes an in game exploit / bug
Fixes #80715
## Changelog
:cl:
fix: Having a netpod destroyed will no longer grant you permanent
healing.
/:cl:

* Fixes netpod healing exploit

---------

Co-authored-by: Jeremiah <[email protected]>
Co-authored-by: NovaBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants