Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fix autosurgeons not respecting implant time #414

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24748
Original PR: tgstation/tgstation#79404

About The Pull Request

Fixes autosurgeons not respecting the passed implant time in use_autosurgeon.

Fixes some spans on autosurgeons.

I noticed it working on a downstream.

Changelog

This will have 0 effect on /tg/, as the only occurrence of passing an implant_time, passed 8 seconds.

No, this will not make self-use autosurgery take time.

…24748)

* Fix autosurgeons not respecting implant time (#79404)

## About The Pull Request

Fixes autosurgeons not respecting the passed implant time in
`use_autosurgeon`.

Fixes some spans on autosurgeons.

I noticed it working on a downstream.

## Changelog

This will have 0 effect on /tg/, as the only occurrence of passing an
`implant_time`, passed 8 seconds.

No, this will not make self-use autosurgery take time.

* Fix autosurgeons not respecting implant time

---------

Co-authored-by: MrMelbert <[email protected]>
@ReezeBL ReezeBL merged commit 7e97fcd into master Nov 3, 2023
24 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-24748 branch November 3, 2023 07:03
Iajret pushed a commit that referenced this pull request Jan 12, 2024
* Makes BSA logging easier to find (#80893)

## About The Pull Request
Admins keep goofing up looking for BSA logs because they currently just
say "an artillery strike" and not "a _bluespace_ artillery strike".
Hopefully this makes it more clear.

I have no clue if this is blocked under the feature freeze, if it is
I'll just reopen it in February.

## Why It's Good For The Game
Us admins have smooth brains sometimes and try to find something using
the most logical terminology. Whoever put this logging in assumed we'd
be smart enough to search for "artillery" and not "bluespace artillery".

## Changelog
:cl:
admin: Made logging for BSA targeting and firing easier to find for
admins.
/:cl:

* Makes BSA logging easier to find

---------

Co-authored-by: Vekter <[email protected]>
Co-authored-by: NovaBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants