Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Fixes species/tongue-based speech modification altering sign language #611

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24983
Original PR: tgstation/tgstation#79685

About The Pull Request

The second part of PR #79677. It works standalone, but is better in tandem.

This PR seeks to correct Signers from having a species/tongue-based speech modification while signing, i.e. no 'Sss'.

Being drunk still affects Signer speech - this is fine for me,

Why It's Good For The Game

Makes sign language more consistent and returns it to its full functionality before it broke.

Changelog

🆑 Danny Boy
fix: Signers no longer sign with their species' tongue
/:cl:

… language [MDB IGNORE] (#24983)

* Fixes species/tongue-based speech modification altering sign language (#79685)

The second part of [PR
standalone, but is better in tandem.

This PR seeks to correct Signers from having a species/tongue-based
speech modification while signing, i.e. no 'Sss'.

Being drunk still affects Signer speech - this is fine for me,

* Fixes species/tongue-based speech modification altering sign language

---------

Co-authored-by: DBGit42 <[email protected]>
@Steals-The-PRs Steals-The-PRs added Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror Fix labels Nov 13, 2023
@ReezeBL ReezeBL merged commit d5f7de3 into master Nov 14, 2023
23 checks passed
@ReezeBL ReezeBL deleted the upstream-mirror-24983 branch November 14, 2023 08:21
AnywayFarus added a commit that referenced this pull request Nov 14, 2023
Iajret pushed a commit that referenced this pull request Jan 25, 2024
* Adds several fire alarms to Birdshot (#81063)

## About The Pull Request
Several rooms were closed in by firelocks but were missing fire alarms,
leading to an entrapment hazard should a fire break out with no crowbars
nearby.
- circuit lab
- hallway outside of circuit lab
- mech bay
- chapel garden
- chapel office
- security hallway outside the office
- warden's office
- evidence storage
- both dormitory private quarters
- atmospherics gas storage
- north and south telecomms antechambers
- library study
- head of personnel quarters
- recreation hallway outside of cytology
- also removed a short line of air supply pipes in cargo delivery office
that went nowhere

In memory of a particular crewmember who perished in a horrible fire, no
crowbar or fire alarm in sight.

I'm not much of a mapper, if any of these seem unnecessary or misplaced
let me know and I can change it.
## Why It's Good For The Game
Additional escape options should a fire break out without a crowbar
handy.
## Changelog
:cl:
fix: Missing fire alarms added to several rooms on Birdshot
/:cl:

* Adds several fire alarms to Birdshot

---------

Co-authored-by: Isratosh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Mirroring conflict git cherry-pick во что-то уткнулся. Не ставить вручную, только для бота TG Mirror
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants