[MIRROR] Allows Signers to send COMSIG_MOB_SAY #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows Signers to send COMSIG_MOB_SAY (#79677) ## About The Pull Request By removing a conditional statement which prevented signers from sending a `COMSIG_MOB_SAY` signal (for some reason), this PR fixes a few things in one go: - Sign language once again prints a notice that the signer raises or lowers their eyebrows for exclamations and questions respectively. - Tonal indicators (sign/typing icons that depict eyebrows raising or lowering) are also working again. - RuneChat is now punctuated the same as the chat box for Signers. This PR is now atomic thanks to @ MrMelbert. * Allows Signers to send COMSIG_MOB_SAY --------- Co-authored-by: DBGit42 <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Nov 14, 2023
Iajret
pushed a commit
that referenced
this pull request
Jan 25, 2024
* [GBP NO UPDATE] Hub time timezone fix (#81053) ## About The Pull Request While browsing the hub I noticed Psychonaut Station the Turkish TG always had "Time:" with a value of many hours. I thought they had long rounds until I joined the server and noticed the actual time was 3 hours behind Turns out time2text() has a timezone arg which defaults to server timezone I have set it to UTC+0 so it is always consistent since world.time is UTC ## Changelog :cl: fix: The hub time should be accurate for servers with different timezones /:cl: * [GBP NO UPDATE] Hub time timezone fix --------- Co-authored-by: 13spacemen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#24982
Original PR: tgstation/tgstation#79677
About The Pull Request
By removing a conditional statement which prevented signers from sending a
COMSIG_MOB_SAYsignal (for some reason), this PR fixes a few things in one go:This PR is now atomic thanks to @ MrMelbert.
Why It's Good For The Game
Repairs intended functionality that broke a while ago. Adds a little flavor and spice to sign conversation again. Makes RuneChat properly register Signer punctuation.
Changelog
🆑 Danny Boy
fix: Fixed Signer eyebrow raising/lowering indicators and emotes
fix: Fixed Signer RuneChat punctuation
/:cl: