Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Makes oculine taste slightly better #829

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25256
Original PR: tgstation/tgstation#79919

About The Pull Request

Changes oculine's taste from 'dull toxin' to 'earthy bitterness'. Probably deserves the no GBP tag.

Why It's Good For The Game

Oculine is a benign/helpful chem that naturally occurs in carrots. This means it's in all carrot based food the chef cooks, and if the carrots cross pollinate with another plant it's in those too. This is currently a problem, because it means the chef's carrot sticks taste like poison and this tends to freak out new players who don't know that's just what oculine tastes like.

Oculine has no negative effects besides potentially triggering a medical allergy quirk, it can't even be overdosed. So if you see a worrying "you taste dull toxin" message, there's actually no reason to be concerned. Still, I see players who are convinced the chef is poisoning their carrot cakes fairly regularly. This should cut down on wasted multiver and lynched chefs.

I changed it to "earthy bitterness" because that's what some species of carrot taste like, and "bitterness" implies medicine. The paranoid can still assume they're being dosed with morphine or something, but they're not being misled into thinking this. For people chugging medicine bottles from chemistry, oculine stands out a little less too.

Changelog

🆑 DaCoolBoss
qol: Oculine now tastes bitter, and not like toxin.
/:cl:

* Makes oculine taste slightly better (#79919)

## About The Pull Request
Changes oculine's taste from 'dull toxin' to 'earthy bitterness'.
Probably deserves the no GBP tag.
## Why It's Good For The Game
Oculine is a benign/helpful chem that naturally occurs in carrots. This
means it's in all carrot based food the chef cooks, and if the carrots
cross pollinate with another plant it's in those too. This is currently
a problem, because it means the chef's carrot sticks taste like poison
and this tends to freak out new players who don't know that's just what
oculine tastes like.

Oculine has no negative effects besides potentially triggering a medical
allergy quirk, it can't even be overdosed. So if you see a worrying "you
taste dull toxin" message, there's actually no reason to be concerned.
Still, I see players who are *convinced* the chef is poisoning their
carrot cakes fairly regularly. This should cut down on wasted multiver
and lynched chefs.

I changed it to "earthy bitterness" because that's what some species of
carrot taste like, and "bitterness" implies medicine. The paranoid can
still assume they're being dosed with morphine or something, but they're
not being misled into thinking this. For people chugging medicine
bottles from chemistry, oculine stands out a little less too.
## Changelog
:cl:
qol: Oculine now tastes bitter, and not like toxin.
/:cl:

* Makes oculine taste slightly better

---------

Co-authored-by: Da Cool Boss <[email protected]>
@Iajret Iajret merged commit c15e0bb into master Nov 26, 2023
24 checks passed
@Iajret Iajret deleted the upstream-mirror-25256 branch November 26, 2023 09:09
AnywayFarus added a commit that referenced this pull request Nov 26, 2023
Iajret pushed a commit that referenced this pull request Feb 7, 2024
* Fixes Alien Hunter's Pounce Visuals (#81322)

## About The Pull Request

Currently on live, when an alien hunter goes for a pounce, once the
pounce is completed the hunter will rise quite a distance slowly from
the floor as setting body_position_pixel_y_offset now is done with
animation as opposed to being instant. This looked extremely stupid, so
I went and fixed it. Initially, I was going to add some form of trait to
cancel out the smoothing effect from a shifting y offset, until I looked
at the sprite for alien pouncing and realized it was 96x96 for no
reason. For reference, 96x96 is the size of Bubblegum's sprites.

So, I just made the sprites 48x32, got rid of the unused sprites
(sentinel and drone both had pounce sprites but neither ever had that
ability iirc) and adjusted some of the pounce ability's internal offset
stuff to compensate and it looks perfectly fine now. Somehow made the
image file larger by 243 bytes according to Github but I guess it is
what it is.

## Why It's Good For The Game

The alien hunter ascending from 2 tiles below where it actually was
whenever it pounced was incredibly jarring. This fixes the problem.

## Changelog
:cl:
fix: Alien Hunter's pounce ability no longer has any weird offset issues
once the pounce is completed.
/:cl:

* Fixes Alien Hunter's Pounce Visuals

---------

Co-authored-by: IndieanaJones <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants