[MIRROR] Add a bounds check to prevent runtimes on the ripple shuttle port #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… port [MDB IGNORE] (#25294) * Add a bounds check to prevent runtimes on the ripple shuttle port (#79959) This appears to sometimes runtime when the target stationary port is somehow a different size to the ripple port. The code had an out of bounds check of a sort, but it doesn't actually work because the array accesses runtime instead of returning a null As to why the turfs available were not the same? most likely because the bounds overlapped the world edge due to a fuck huge shuttle. I have a feeling even if this proc completes something would fail later anyway. edit: oh so it was the lance shuttle which is fuck hueg #79961 is related but not fixed by this. * Add a bounds check to prevent runtimes on the ripple shuttle port --------- Co-authored-by: oranges <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25294
Original PR: tgstation/tgstation#79959
This appears to sometimes runtime when the target stationary port is somehow a different size to the ripple port. The code had an out of bounds check of a sort, but it doesn't actually work because the array accesses runtime instead of returning a null
As to why the turfs available were not the same? most likely because the bounds overlapped the world edge due to a fuck huge shuttle.
I have a feeling even if this proc completes something would fail later anyway.
edit: oh so it was the lance shuttle which is fuck hueg
#79961 is related but not fixed by this.