[MIRROR] Sign Language action now properly updates its background when toggled #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n toggled [MDB IGNORE] (#25376) * Sign Language action now properly updates its background when toggled (#80052) ## About The Pull Request Changes two lines in `sign_language.dm` such that it actually updates its background when toggled, rather than only when forced to update by some other signal. ## Why It's Good For The Game The Sign Language action has a visual distinction for whether it's active or not, but it did not update this properly when toggled. This fixes that problem. ## Changelog :cl: fix: Sign Language action properly toggles between an active/inactive background again. /:cl: * Sign Language action now properly updates its background when toggled --------- Co-authored-by: _0Steven <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Dec 2, 2023
Iajret
pushed a commit
that referenced
this pull request
Feb 11, 2024
…e render game plane instead (#914) * Client colo(u)r no longer uses Client.color, now coloring the render game plane instead (#81328) ## About The Pull Request Rather than utilizing `client.color`, client color datums now apply their colors to the render game plane. This means 1. The player's HUD is no longer affected by client colors. Being colorblind (in game) no longer makes all hud elements grey as well, only the world. 2. Overall, less harsh colors. ## Why It's Good For The Game 1. The player's HUD, being an OOC concept, should remain unaffected by stuff like glasses and blindness. This is how it worked in the past, before plane cube (IIRC), but it was lost in the transition. 2. Overall just looks a lot better, IMO. Here's what meson goggles with glasses colors active looks like: Before:  After:  ## Changelog :cl: Melbert qol: Glasses colors should be a lot less harsh, and being blind no longer also blinds your hud. /:cl: * Client colo(u)r no longer uses Client.color, now coloring the render game plane instead --------- Co-authored-by: MrMelbert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25376
Original PR: tgstation/tgstation#80052
About The Pull Request
Changes two lines in
sign_language.dmsuch that it actually updates its background when toggled, rather than only when forced to update by some other signal.Why It's Good For The Game
The Sign Language action has a visual distinction for whether it's active or not, but it did not update this properly when toggled. This fixes that problem.
Changelog
🆑 00-Steven
fix: Sign Language action properly toggles between an active/inactive background again.
/:cl: